IDL: Basic dictionary inheritance support

Source/bindings/tests/results/core/TestDictionaryDerived.h

Index: Source/bindings/tests/results/core/TestDictionaryDerived.h
diff --git a/Source/bindings/tests/results/core/TestDictionaryDerived.h b/Source/bindings/tests/results/core/TestDictionaryDerived.h
new file mode 100644
index 0000000000000000000000000000000000000000..24031243d1b57061747f49c897606e97c99325dc
--- /dev/null
+++ b/Source/bindings/tests/results/core/TestDictionaryDerived.h
@@ -0,0 +1,40 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
+
+#ifndef TestDictionaryDerivedImplementedAs_h
+#define TestDictionaryDerivedImplementedAs_h
+
+#include "bindings/tests/idls/core/TestDictionary.h"
+#include "platform/heap/Handle.h"
+#include "wtf/text/WTFString.h"
+
+namespace blink {
+
+class TestDictionaryDerivedImplementedAs : public TestDictionary {

[haraken, 2014/11/19 09:11:26]

Add final.

[bashi, 2014/11/19 11:04:43]

It somewhat difficult to know whether the class doesn't have subclasses (need to
know all inheritance hierarchy). I'd like to address it later. Added a FIXME
comment.

[haraken, 2014/11/19 11:50:32]

Makes sense. You don't need to try hard to add final. Simplicity of the IDL
compiler would be more important.

+    ALLOW_ONLY_INLINE_ALLOCATION();
+public:
+    TestDictionaryDerivedImplementedAs();
+
+    bool hasDerivedStringMember() const { return !m_derivedStringMember.isNull(); }
+    String derivedStringMember() const { return m_derivedStringMember; }
+    void setDerivedStringMember(String value) { m_derivedStringMember = value; }
+
+    bool hasDerivedStringMemberWithDefault() const { return !m_derivedStringMemberWithDefault.isNull(); }
+    String derivedStringMemberWithDefault() const { return m_derivedStringMemberWithDefault; }
+    void setDerivedStringMemberWithDefault(String value) { m_derivedStringMemberWithDefault = value; }
+
+    virtual void trace(Visitor*);

[haraken, 2014/11/19 09:11:26]

Can we add override ?

[bashi, 2014/11/19 11:04:43]

Unfortunately, no. We use the same template for the base class and derived
class.

[haraken, 2014/11/19 11:50:32]

Ditto.

+
+private:
+    String m_derivedStringMember;
+    String m_derivedStringMemberWithDefault;
+
+    friend class V8TestDictionaryDerivedImplementedAs;
+};
+
+} // namespace blink
+
+#endif // TestDictionaryDerivedImplementedAs_h