Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 740423002: bookmarks: Move BaseBookmarkModelObserver into 'bookmarks' namespace. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, sdefresne, blundell, nshaik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Move BaseBookmarkModelObserver into 'bookmarks' namespace. BUG=370433 TEST=components_unittests, unit_tests R=sky@chromium.org Committed: https://crrev.com/92fe70f94b0927f7d4d6ead49f04a777f8c7023e Cr-Commit-Position: refs/heads/master@{#305090}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -35 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/external_process_importer_host.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/bookmark_model_loaded_observer.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/wrench_menu.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/base_bookmark_model_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/base_bookmark_model_observer.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
6 years, 1 month ago (2014-11-20 17:32:27 UTC) #1
sky
LGTM
6 years, 1 month ago (2014-11-20 20:21:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740423002/20001
6 years, 1 month ago (2014-11-20 21:28:57 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 22:36:45 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:37:27 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/92fe70f94b0927f7d4d6ead49f04a777f8c7023e
Cr-Commit-Position: refs/heads/master@{#305090}

Powered by Google App Engine
This is Rietveld 408576698