chrome/browser/ui/bookmarks/bookmark_tab_helper.h - Issue 740423002: bookmarks: Move BaseBookmarkModelObserver into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.h

Issue 740423002: bookmarks: Move BaseBookmarkModelObserver into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_tab_helper.h

diff --git a/chrome/browser/ui/bookmarks/bookmark_tab_helper.h b/chrome/browser/ui/bookmarks/bookmark_tab_helper.h

index 6e2c343dedcb9337cd23e7dea46c24732456caad..5e840ab1ddc9cd637d440a13a1f16b051786735d 100644

--- a/chrome/browser/ui/bookmarks/bookmark_tab_helper.h

+++ b/chrome/browser/ui/bookmarks/bookmark_tab_helper.h

@@ -21,7 +21,7 @@ class WebContents;

// Per-tab class to manage bookmarks.

class BookmarkTabHelper

- : public BaseBookmarkModelObserver,

+ : public bookmarks::BaseBookmarkModelObserver,

public content::WebContentsObserver,

public content::WebContentsUserData<BookmarkTabHelper> {

public:

@@ -65,7 +65,7 @@ class BookmarkTabHelper

// the delegate is notified.

void UpdateStarredStateForCurrentURL();

- // Overridden from BaseBookmarkModelObserver:

+ // Overridden from bookmarks::BaseBookmarkModelObserver:

void BookmarkModelChanged() override;

void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;

void BookmarkNodeAdded(BookmarkModel* model,