Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 740223003: Revive tests for Document.createAttributeNS() and Element.setAttributeNodeNS() (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
pdr.
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revive tests for Document.createAttributeNS() and Element.setAttributeNodeNS() This brings back some tests removed in https://codereview.chromium.org/158593003 and https://codereview.chromium.org/143173003 They modify some of the same tests, so reverting together is simpler. BUG=341296, 341830 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185721

Patch Set 1 #

Patch Set 2 : deprecation messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -259 lines) Patch
A + LayoutTests/dom/html/level2/core/createAttributeNS06.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/html/level2/core/createAttributeNS06.js View 4 chunks +9 lines, -11 lines 0 comments Download
A LayoutTests/dom/html/level2/core/createAttributeNS06-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/dom/xhtml/level2/core/createAttributeNS06.js View 4 chunks +9 lines, -11 lines 0 comments Download
A + LayoutTests/dom/xhtml/level2/core/createAttributeNS06.xhtml View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/dom/xhtml/level2/core/createAttributeNS06-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/attrisid06.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode03.js View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode04.js View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode06.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentrenamenode21.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentrenamenode22.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking01.js View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking02.js View 3 chunks +12 lines, -12 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/documentsetstricterrorchecking02.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition15.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodegettextcontent08.js View 4 chunks +12 lines, -10 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodegettextcontent08.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent08-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeinsertbefore03.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeinsertbefore14.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeinsertbefore20.js View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisdefaultnamespace16.js View 3 chunks +13 lines, -15 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisdefaultnamespace16.xhtml View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode14.js View 4 chunks +10 lines, -13 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode14.xhtml View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode15.js View 4 chunks +25 lines, -13 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode15.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeisequalnode17.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodeisequalnode18.js View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode19.js View 4 chunks +9 lines, -13 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode19.xhtml View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode20.js View 4 chunks +10 lines, -12 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodeisequalnode20.xhtml View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16.js View 3 chunks +14 lines, -13 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodelookupprefix16.js View 2 chunks +17 lines, -19 lines 0 comments Download
A + LayoutTests/dom/xhtml/level3/core/nodelookupprefix16.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodelookupprefix16-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild20.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild34.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild35.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild36.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodereplacechild37.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent06.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/dom/xhtml/level3/core/wellformed04.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt View 1 2 chunks +4 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/Document/createAttributeNS-namespace-err.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/Document/createAttributeNS-namespace-err-expected.txt View 1 chunk +53 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/Document/script-tests/createAttributeNS-namespace-err.js View 3 chunks +26 lines, -38 lines 0 comments Download
M LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/script-tests/attr-param-typechecking.js View 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/Element/script-tests/setAttributeNS-namespace-err.js View 3 chunks +21 lines, -37 lines 0 comments Download
A + LayoutTests/fast/dom/Element/setAttributeNS-namespace-err.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/Element/setAttributeNS-namespace-err-expected.txt View 1 chunk +51 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/setAttributeNode-case-insensitivity.html View 1 chunk +28 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt View 2 chunks +8 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Node/initial-values-expected.txt View 2 chunks +16 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Node/script-tests/initial-values.js View 2 chunks +20 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/coreDOM-element-attribute-js-null.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/serialize-nodes.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
philipj_slow
PTAL. In some tests the use of these functions is incidental and can be avoided, ...
6 years, 1 month ago (2014-11-20 15:44:42 UTC) #2
philipj_slow
deprecation messages
6 years, 1 month ago (2014-11-20 19:30:05 UTC) #3
pdr.
On 2014/11/20 at 15:44:42, philipj wrote: > PTAL. In some tests the use of these ...
6 years, 1 month ago (2014-11-20 19:30:39 UTC) #4
philipj_slow
On 2014/11/20 19:30:39, pdr wrote: > On 2014/11/20 at 15:44:42, philipj wrote: > > PTAL. ...
6 years, 1 month ago (2014-11-20 19:33:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740223003/20001
6 years, 1 month ago (2014-11-20 19:35:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/20307)
6 years, 1 month ago (2014-11-20 20:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740223003/20001
6 years, 1 month ago (2014-11-20 22:21:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/20322)
6 years, 1 month ago (2014-11-20 22:45:38 UTC) #13
philipj_slow
Presubmit will not forgive the tabs and trailing whitespace in these tests, I'll have to ...
6 years, 1 month ago (2014-11-20 23:17:35 UTC) #14
philipj_slow
6 years, 1 month ago (2014-11-20 23:27:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 185721 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698