Remove unused feature ElementSetAttributeNodeNS

Remove unused feature ElementSetAttributeNodeNS

Intent to Deprecate and Remove:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jS7iCEmoWfQ

BUG=341296
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166699

[silverroots, 2014-02-06 03:41:52]

Deprecated as of now with layout tests rebaseline. Please review. Thanks.

[ojan, 2014-02-06 04:59:08]

Since we already know that the feature has really low usage, I don't think
we need to go through the process of deprecating it first. We can just
remove the feature in one go.


On Wed, Feb 5, 2014 at 7:41 PM, <kaustubh.a@samsung.com> wrote:

> Reviewers: ojan, Chris Dumez, philipj, jochen,
>
> Message:
> Deprecated as of now with layout tests rebaseline. Please review. Thanks.
>
> Description:
> Deprecate unused feature ElementSetAttributeNodeNS
>
> Intent to Deprecate:
>     https://groups.google.com/a/chromium.org/forum/#!topic/
> blink-dev/jS7iCEmoWfQ
>
> BUG=341296
>
> Please review this at https://codereview.chromium.org/143173003/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+14, -1 lines):
>   M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11-
> expected.txt
>   M LayoutTests/dom/xhtml/level3/core/nodegettextcontent08-expected.txt
>   M LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-
> expected.txt
>   M LayoutTests/dom/xhtml/level3/core/nodelookupprefix16-expected.txt
>   M LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt
>   M LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt
>   M LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
>   M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-
> context-frame-src-setAttributeNodeNS-expected.txt
>   M LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-
> context-iframe-src-setAttributeNodeNS-expected.txt
>   M LayoutTests/http/tests/security/xss-DENIED-iframe-
> src-alias-expected.txt
>   M Source/core/dom/Element.idl
>   M Source/core/frame/UseCounter.cpp
>
>
> Index: LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11-
> expected.txt
> diff --git a/LayoutTests/dom/xhtml/level3/core/
> nodecomparedocumentposition11-expected.txt b/LayoutTests/dom/xhtml/
> level3/core/nodecomparedocumentposition11-expected.txt
> index eb1e97ec6ad9ed068a29b2f2a43db20de8f51a13..
> 4769579bfd65de1dbcbe41e7a200e9c082dcb18f 100644
> --- a/LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11-
> expected.txt
> +++ b/LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11-
> expected.txt
> @@ -1,2 +1,3 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  Test   http://www.w3.org/2001/DOM-Test-Suite/level3/core/
> nodecomparedocumentposition11
>  Status Success
> Index: LayoutTests/dom/xhtml/level3/core/nodegettextcontent08-expected.txt
> diff --git a/LayoutTests/dom/xhtml/level3/core/
> nodegettextcontent08-expected.txt b/LayoutTests/dom/xhtml/level3/core/
> nodegettextcontent08-expected.txt
> index 0f82bc0bd954b9126e04c21885b1939dbc3f8116..
> a09e1dd6bc31fe442da157e9f7ec807e30489d7b 100644
> --- a/LayoutTests/dom/xhtml/level3/core/nodegettextcontent08-expected.txt
> +++ b/LayoutTests/dom/xhtml/level3/core/nodegettextcontent08-expected.txt
> @@ -1,2 +1,3 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  Test   http://www.w3.org/2001/DOM-Test-Suite/level3/core/
> nodegettextcontent08
>  Status Success
> Index: LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-
> expected.txt
> diff --git
a/LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt
> b/LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt
> index 1b617936ce483cbf017f4db743147bf921fb62a1..
> e391b613c256833ea92ec9b06889807b298678d4 100644
> --- a/LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-
> expected.txt
> +++ b/LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-
> expected.txt
> @@ -1,2 +1,3 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  Test   http://www.w3.org/2001/DOM-Test-Suite/level3/core/
> nodelookupnamespaceuri16
>  Status Success
> Index: LayoutTests/dom/xhtml/level3/core/nodelookupprefix16-expected.txt
> diff --git a/LayoutTests/dom/xhtml/level3/core/
> nodelookupprefix16-expected.txt b/LayoutTests/dom/xhtml/level3/core/
> nodelookupprefix16-expected.txt
> index 9ba8835518b3e9c3b6be39fa468a30726863da15..
> f2cdf6a741331abd059b2a9ee6532155fd7ebc0c 100644
> --- a/LayoutTests/dom/xhtml/level3/core/nodelookupprefix16-expected.txt
> +++ b/LayoutTests/dom/xhtml/level3/core/nodelookupprefix16-expected.txt
> @@ -1,2 +1,3 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  Test   http://www.w3.org/2001/DOM-Test-Suite/level3/core/
> nodelookupprefix16
>  Status Success
> Index: LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt
> diff --git a/LayoutTests/dom/xhtml/level3/core/
> nodesettextcontent06-expected.txt b/LayoutTests/dom/xhtml/level3/core/
> nodesettextcontent06-expected.txt
> index 8393c56d973c0e75a89795383c6a055fb1238a1a..
> 283a8991b5dd70c9389c193285693806099e5144 100644
> --- a/LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt
> +++ b/LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt
> @@ -1,2 +1,3 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  Test   http://www.w3.org/2001/DOM-Test-Suite/level3/core/
> nodesettextcontent06
>  Status Success
> Index: LayoutTests/fast/css/lang-mapped-to-webkit-locale-
> dynamic-expected.txt
> diff --git
a/LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt
> b/LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt
> index 52e138d1c27e70047ef2aa39f494d47e24610859..
> 13622d4b31b65b433175d4097f7507a9ee8eb9ad 100644
> --- a/LayoutTests/fast/css/lang-mapped-to-webkit-locale-
> dynamic-expected.txt
> +++ b/LayoutTests/fast/css/lang-mapped-to-webkit-locale-
> dynamic-expected.txt
> @@ -1,3 +1,4 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  This tests mapping of lang/xml:lang to -webkit-locale with dynamic
> attribute changes. WebKit bug 76364
>
>  On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".
> Index: LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
> diff --git
a/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
> b/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
> index 0aad760031b96c09f796f6deb8789de48141525f..
> 9b7f31178de082ee7c020067c627a11ce7bafda2 100644
> --- a/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
> +++ b/LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt
> @@ -1,3 +1,4 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  This test checks whether passing wrong types to setAttributeNode causes a
> crash.
>
>  On success, you will see a series of "PASS" messages, followed by "TEST
> COMPLETE".
> Index: LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt
> diff --git a/LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt
> b/LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-
> context-frame-src-setAttributeNodeNS-expected.txt
> index be3c9862b1d00372d7e01c1819c18f8edb1f0840..
> 8b3874236a43bcbef3c56a172d4a81120471c739 100644
> --- a/LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt
> +++ b/LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt
> @@ -1,3 +1,4 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8000". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8000". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8000". Protocols,
> domains, and ports must match.
> Index: LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt
> diff --git a/LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt
> b/LayoutTests/http/tests/security/javascriptURL/javascriptURL-execution-
> context-iframe-src-setAttributeNodeNS-expected.txt
> index 0b9eb3ed2633fb3a38817bdf47771bc6737f304e..
> 421fed958111bfae94402dfddca968234151a33e 100644
> --- a/LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt
> +++ b/LayoutTests/http/tests/security/javascriptURL/
> javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt
> @@ -1,3 +1,4 @@
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8000". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8000". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8000". Protocols,
> domains, and ports must match.
> Index: LayoutTests/http/tests/security/xss-DENIED-iframe-
> src-alias-expected.txt
> diff --git
a/LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt
> b/LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt
> index b56727066fe8b33a18a0edbb86e55a765fe27612..
> 3b39bcec8ca5cb7fe36fdaa7fb1bd821e1dc4370 100644
> --- a/LayoutTests/http/tests/security/xss-DENIED-iframe-
> src-alias-expected.txt
> +++ b/LayoutTests/http/tests/security/xss-DENIED-iframe-
> src-alias-expected.txt
> @@ -7,6 +7,7 @@ CONSOLE ERROR: Blocked a frame with origin "
> http://127.0.0.1:8000" from accessin
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8080". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8080". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8080". Protocols,
> domains, and ports must match.
> +CONSOLE WARNING: 'Element.setAttributeNodeNS()' is deprecated.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8080". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8080". Protocols,
> domains, and ports must match.
>  CONSOLE ERROR: Blocked a frame with origin "http://127.0.0.1:8000" from
> accessing a frame with origin "http://localhost:8080". Protocols,
> domains, and ports must match.
> Index: Source/core/dom/Element.idl
> diff --git a/Source/core/dom/Element.idl b/Source/core/dom/Element.idl
> index b8d54ddbc0254f5a5ac0ba989e052e14c9f803ba..
> 29745afaab8504785881c039a90243aec2732ba7 100644
> --- a/Source/core/dom/Element.idl
> +++ b/Source/core/dom/Element.idl
> @@ -45,7 +45,7 @@
>      HTMLCollection getElementsByTagNameNS([TreatNullAs=NullString]
> DOMString namespaceURI, DOMString localName);
>      [MeasureAs=ElementGetAttributeNodeNS] Attr getAttributeNodeNS([
> TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,
>
>  [Default=Undefined] optional DOMString localName); // Removed from DOM4.
> -    [RaisesException, CustomElementCallbacks,
MeasureAs=ElementSetAttributeNodeNS]
> Attr setAttributeNodeNS([Default=Undefined, StrictTypeChecking] optional
> Attr newAttr); // Removed from DOM4.
> +    [RaisesException, CustomElementCallbacks,
DeprecateAs=ElementSetAttributeNodeNS]
> Attr setAttributeNodeNS([Default=Undefined, StrictTypeChecking] optional
> Attr newAttr); // Removed from DOM4.
>      boolean hasAttribute(DOMString name);
>      boolean hasAttributeNS([TreatNullAs=NullString] DOMString
> namespaceURI, DOMString localName);
>
> Index: Source/core/frame/UseCounter.cpp
> diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/
> UseCounter.cpp
> index 5890c86864790cd946b5fa7fccdbeb840e52e478..
> 11445a8ec2119c10090ca655ef92816a283cb865 100644
> --- a/Source/core/frame/UseCounter.cpp
> +++ b/Source/core/frame/UseCounter.cpp
> @@ -709,6 +709,9 @@ String UseCounter::deprecationMessage(Feature feature)
>      case HTMLSourceElementMedia:
>          return "'HTMLSourceElement.media' is deprecated. This attribute
> doesn't do anything.";
>
> +    case ElementSetAttributeNodeNS:
> +        return "'Element.setAttributeNodeNS()' is deprecated.";
> +
>      // Features that aren't deprecated don't have a deprecation message.
>      default:
>          return String();
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[silverroots, 2014-02-06 06:40:26]

On 2014/02/06 04:59:08, ojan wrote:
> Since we already know that the feature has really low usage, I don't think
> we need to go through the process of deprecating it first. We can just
> remove the feature in one go.
> 

Sounds good to me. I will update the patch.

[silverroots, 2014-02-06 11:26:21]

On 2014/02/06 06:40:26, silverroots wrote:
> On 2014/02/06 04:59:08, ojan wrote:
> > Since we already know that the feature has really low usage, I don't think
> > we need to go through the process of deprecating it first. We can just
> > remove the feature in one go.
> > 
> 
> Sounds good to me. I will update the patch.

Added new patch to review.

[ojan, 2014-02-06 19:01:15]

lgtm

[ojan, 2014-02-06 19:02:01]

The CQ bit was unchecked by ojan@chromium.org

[ojan, 2014-02-06 19:31:27]

https://codereview.chromium.org/143173003/diff/60001/Source/core/dom/Element.idl
File Source/core/dom/Element.idl (left):

https://codereview.chromium.org/143173003/diff/60001/Source/core/dom/Element....
Source/core/dom/Element.idl:48: [RaisesException, CustomElementCallbacks,
MeasureAs=ElementSetAttributeNodeNS] Attr setAttributeNodeNS([Default=Undefined,
StrictTypeChecking] optional Attr newAttr); // Removed from DOM4.
Can you also update the UseCounter enum (i.e. prefixed it with REMOVED)?

[silverroots, 2014-02-07 04:31:38]

The CQ bit was checked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 04:31:38]

The CQ bit was unchecked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 04:31:38]

The CQ bit was checked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 04:31:39]

The CQ bit was unchecked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 04:31:39]

The CQ bit was unchecked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 04:31:39]

The CQ bit was checked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 04:31:40]

The CQ bit was checked by kaustubh.a@samsung.com

[commit-bot: I haz the power, 2014-02-07 04:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaustubh.a@samsung.com/143173003/130001

[commit-bot: I haz the power, 2014-02-07 06:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-07 06:44:13]

Retried try job too often on mac_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...

[silverroots, 2014-02-07 07:15:44]

The CQ bit was unchecked by kaustubh.a@samsung.com

[silverroots, 2014-02-07 07:15:44]

The CQ bit was checked by kaustubh.a@samsung.com

[commit-bot: I haz the power, 2014-02-07 07:15:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaustubh.a@samsung.com/143173003/360001

[commit-bot: I haz the power, 2014-02-07 09:30:54]

Change committed as 166699