Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 740203002: Fix download shelf visibility bug introduced by nullptr change. (Closed)

Created:
6 years, 1 month ago by benwells
Modified:
6 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix download shelf visibility bug introduced by nullptr change. The bug caused the download shelf visibility to not be updated correctly. BUG=434594 Committed: https://crrev.com/53513eb643e20eff90854990a494057c1f4f6014 Cr-Commit-Position: refs/heads/master@{#305118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
doh.
6 years, 1 month ago (2014-11-20 07:09:05 UTC) #2
James Cook
Doh! :-) LGTM
6 years, 1 month ago (2014-11-20 16:28:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740203002/1
6 years, 1 month ago (2014-11-20 23:10:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 00:11:39 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:13:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53513eb643e20eff90854990a494057c1f4f6014
Cr-Commit-Position: refs/heads/master@{#305118}

Powered by Google App Engine
This is Rietveld 408576698