chrome/browser/ui/views/frame/browser_view.cc - Issue 740203002: Fix download shelf visibility bug introduced by nullptr change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 740203002: Fix download shelf visibility bug introduced by nullptr change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 7c92feda8fb1cc748b61a9df9489ab179e1b3210..185bdc062844197d9f816dd89af8884f3f486320 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1215,8 +1215,7 @@ void BrowserView::SetDownloadShelfVisible(bool visible) {

GetDownloadShelf();

}

- if (!browser_)

- browser_->UpdateDownloadShelfVisibility(visible);

+ browser_->UpdateDownloadShelfVisibility(visible);

// SetDownloadShelfVisible can force-close the shelf, so make sure we lay out

// everything correctly, as if the animation had finished. This doesn't

« no previous file with comments | « no previous file | no next file » | no next file with comments »