Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 7398032: Merge 90599 - Work around Skia PDF's lack of inverted path support. (Closed)

Created:
7 years, 11 months ago by Chris Guillory
Modified:
7 years, 11 months ago
Reviewers:
Chris Guillory
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 90599 - Work around Skia PDF's lack of inverted path support. https://bugs.webkit.org/show_bug.cgi?id=64032 Patch by Steve VanDeBogart <vandebo@chromium.org>; on 2011-07-07 Reviewed by James Robinson. The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html to support antialiased clips doesn't work when printing to Skia's PDF backend because the backend does not support inverted paths. This manifests as rounded buttons not being drawn when printing, tracked as Chrome bug 79519. However, when the output is a vector device, like PDF, we don't need antialiased clips. It's up to the PDF rendering engine to do that. So we can simply disable the antialiased clip code if the output is a vector device. I think the fix isn't testable because it requires examining the printed output. * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::clipPathAntiAliased): TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91207

Patch Set 1 #

Patch Set 2 : Fixing ChangeLog entry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M Source/WebCore/ChangeLog View 1 1 chunk +21 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Chris Guillory
7 years, 11 months ago (2011-07-18 20:43:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698