Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: Source/WebCore/ChangeLog

Issue 7398032: Merge 90599 - Work around Skia PDF's lack of inverted path support. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/782/
Patch Set: Fixing ChangeLog entry. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 2011-07-07 Steve VanDeBogart <vandebo@chromium.org>
2
3 Work around Skia PDF's lack of inverted path support.
4 https://bugs.webkit.org/show_bug.cgi?id=64032
5
6 Reviewed by James Robinson.
7
8 The trick used in http://neugierig.org/software/chromium/notes/2010/07/c lipping.html
9 to support antialiased clips doesn't work when printing to Skia's PDF ba ckend because
10 the backend does not support inverted paths. This manifests as rounded b uttons not being
11 drawn when printing, tracked as Chrome bug 79519.
12
13 However, when the output is a vector device, like PDF, we don't need ant ialiased clips.
14 It's up to the PDF rendering engine to do that. So we can simply disabl e the antialiased
15 clip code if the output is a vector device.
16
17 I think the fix isn't testable because it requires examining the printed output.
18
19 * platform/graphics/skia/PlatformContextSkia.cpp:
20 (WebCore::PlatformContextSkia::clipPathAntiAliased):
21
1 2011-06-23 John Bates <jbates@google.com> 22 2011-06-23 John Bates <jbates@google.com>
2 23
3 Reviewed by James Robinson. 24 Reviewed by James Robinson.
4 25
5 Fix latch deadlock when GPU process crashes or context is lost. 26 Fix latch deadlock when GPU process crashes or context is lost.
6 https://bugs.webkit.org/show_bug.cgi?id=63189 27 https://bugs.webkit.org/show_bug.cgi?id=63189
7 The main bug fix is to only set/wait latches if the child context has no errors. 28 The main bug fix is to only set/wait latches if the child context has no errors.
8 Additionally, the LayerChromium classes needed to be modified to not con tinue drawing when 29 Additionally, the LayerChromium classes needed to be modified to not con tinue drawing when
9 their corresponding contexts have errors. Otherwise, they would draw wit h invalid texture ids. 30 their corresponding contexts have errors. Otherwise, they would draw wit h invalid texture ids.
10 31
(...skipping 14725 matching lines...) Expand 10 before | Expand all | Expand 10 after
14736 fast/viewport/viewport-45.html fails in GTK+/Qt 14757 fast/viewport/viewport-45.html fails in GTK+/Qt
14737 https://bugs.webkit.org/show_bug.cgi?id=47481 14758 https://bugs.webkit.org/show_bug.cgi?id=47481
14738 14759
14739 computeViewportAttributes does many math operations with float point ari thmetic 14760 computeViewportAttributes does many math operations with float point ari thmetic
14740 and in some cases there is loss of precision making tests have incorrect values. 14761 and in some cases there is loss of precision making tests have incorrect values.
14741 14762
14742 * dom/ViewportArguments.cpp: 14763 * dom/ViewportArguments.cpp:
14743 (WebCore::computeViewportAttributes): 14764 (WebCore::computeViewportAttributes):
14744 14765
14745 == Rolled over to ChangeLog-2011-06-04 == 14766 == Rolled over to ChangeLog-2011-06-04 ==
OLDNEW
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698