Close bubbles not on UpdateToolbar but when the activated tab is changed

chrome/browser/ui/views/location_bar/location_bar_view.cc

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 56181b8b0a116782fac57d50d56bc62326a211a2..09ab4ee5eb0a6ebfbf92851b4796984ef1f03c61 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -971,7 +971,6 @@ void LocationBarView::Update(const WebContents* contents) {
   RefreshContentSettingViews();
   generated_credit_card_view_->Update();
   ZoomBubbleView::CloseBubble();
-  TranslateBubbleView::CloseBubble();

[Peter Kasting, 2014/11/19 09:18:12]

What about the other statements here, e.g. ZoomBubbleView::CloseBubble()? 
Wouldn't that be wrong too?  Can the other updating functions here do the wrong
things as well?

[hajimehoshi, 2014/11/19 10:02:08]

As to the zoom bubble, maybe yes, and I can update this. I'm not sure about the
other functions.

I said 'maybe' because you said this was the right place to close the zoom
bubble before (https://codereview.chromium.org/425223003). But if my findings
are right and new to you, we should move updating the zoom bubble.

BTW, being different from the Translate bubble, the zoom bubble is closed after
several seconds automatically in some cases, so I suppose users don't notice
that the zoom bubble is closed by non-navigation events.

   RefreshZoomView();
   RefreshPageActionViews();
   RefreshTranslateIcon();
@@ -1153,6 +1152,9 @@ void LocationBarView::RefreshTranslateIcon() {
   command_updater()->UpdateCommandEnabled(IDC_TRANSLATE_PAGE, enabled);
   translate_icon_view_->SetVisible(enabled);
   translate_icon_view_->SetToggled(language_state.IsPageTranslated());
+
+  if (!enabled)
+    TranslateBubbleView::CloseBubble();

[Peter Kasting, 2014/11/19 09:18:12]

Does this close the bubble when the main frame is navigated?  (I presume yes,
otherwise main frame navigations wouldn't close the bubble at all, which seems
wrong)

[hajimehoshi, 2014/11/19 10:02:08]

Yes. When the main frame is navigated, |enabled| should be false.

 }
 
 bool LocationBarView::RefreshManagePasswordsIconView() {