chrome/browser/ui/browser.cc - Issue 739793003: Close bubbles not on UpdateToolbar but when the activated tab is changed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 739793003: Close bubbles not on UpdateToolbar but when the activated tab is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 97ae8c627328e61996eb299716daa10c3628b509..a034ed28db6595c94a5af22ab13d99bb2352adba 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1015,6 +1015,7 @@ void Browser::ActiveTabChanged(WebContents* old_contents,

// Propagate the profile to the location bar.

UpdateToolbar((reason & CHANGE_REASON_REPLACED) == 0);

+ window_->CloseTranslateBubble();

Peter Kasting 2014/11/19 09:18:12 Why do we need a special call for this? Why can't

hajimehoshi 2014/11/19 10:02:08 Ah, you're right. Done.

if (chrome::IsInstantExtendedAPIEnabled())

search_delegate_->OnTabActivated(new_contents);

« no previous file with comments | « no previous file | chrome/browser/ui/browser_window.h » ('j') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('J')