tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py ('k') | tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

index 59e009b3d1849f5684fc851fa28d07e38bdd62ef..5310fc7ddb6601e758a3858d0f6ff072cf3304f6 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py

@@ -15,7 +15,7 @@ from telemetry.core.backends.chrome import system_info_backend

class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

_DEBUGGER_URL_BUILDER = 'ws://localhost:%i/devtools/page/%i'

- _DEBUGGER_URL_REGEX = 'ws://localhost:(\d+)/devtools/page/(\d+)'

+ _DEBUGGER_URL_REGEX = r'ws://localhost:(\d+)/devtools/page/(\d+)'

_DEVICE_LIST_URL = 'http://localhost:9221/json'

def __init__(self, ios_platform_backend, browser_options):

@@ -76,6 +76,7 @@ class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

def GetData():

try:

with contextlib.closing(

+ # pylint: disable=cell-var-from-loop

urllib2.urlopen('http://%s/json' % d['url'])) as f:

json_result = f.read()

data = json.loads(json_result)