tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py - Issue 739623005: [Telemetry] Resolve errors due to new pylint checker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py

Issue 739623005: [Telemetry] Resolve errors due to new pylint checker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready to land Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_network_unittest.py ('k') | tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py

index 9e3596a622914ade57a06fe177c809b0d60bfb1d..0d03ac199825b1371c92955af43ab5044bf7bcc0 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_websocket_unittest.py

@@ -70,6 +70,7 @@ class InspectorWebsocketUnittest(unittest.TestCase):

inspector = inspector_websocket.InspectorWebsocket(

notification_handler=lambda data: True,

error_handler=_ReraiseExceptionErrorHandler)

+ # pylint: disable=protected-access

inspector._socket = FakeSocket(self._mock_timer)

# The third call to socket.recv() will take 15 seconds without any data

# received, hence the below call will raise a

@@ -82,6 +83,7 @@ class InspectorWebsocketUnittest(unittest.TestCase):

inspector = inspector_websocket.InspectorWebsocket(

notification_handler=lambda data: True,

error_handler=_DoNothingExceptionErrorHandler)

+ # pylint: disable=protected-access

inspector._socket = FakeSocket(self._mock_timer)

# The third and forth calls to socket.recv() will take 30 seconds without

# any data received, hence the below call will raise a

@@ -93,7 +95,9 @@ class InspectorWebsocketUnittest(unittest.TestCase):

def testDispatchNotificationUntilDoneNotTimedOut(self):

inspector = inspector_websocket.InspectorWebsocket(

notification_handler=lambda data: True,

+ # pylint: disable=protected-access

error_handler=_ReraiseExceptionErrorHandler)

+ # pylint: disable=protected-access

inspector._socket = FakeSocket(self._mock_timer)

# Even though it takes 70 seconds to receive all the data, the call below

# will succeed since there are no interval which the previous data package