Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(350)

Issue 7396024: Adding a sync_guid field to TemplateURL. Adding appropriate database migration changes and tests. (Closed)

Created:
7 years, 8 months ago by SteveT
Modified:
7 years, 8 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., dhollowa
Visibility:
Public.

Description

Adding a sync_guid field to TemplateURL. Adding appropriate database migration changes and tests. TEST=Ensure that all changed unittests pass. BUG=15548 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93039

Patch Set 1 #

Patch Set 2 : Lint fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -10 lines) Patch
M chrome/browser/search_engines/template_url.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/protocol/search_engine_specifics.proto View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/webdata/keyword_table.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/webdata/keyword_table.cc View 1 8 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_database_migration_unittest.cc View 1 2 chunks +41 lines, -1 line 0 comments Download
A chrome/test/data/web_database/version_38.sql View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
SteveT
Nick: As discussed, I am adding a GUID field to TemplateURL (the search engine data ...
7 years, 8 months ago (2011-07-18 17:44:59 UTC) #1
sky
I don't see you setting the guid anywhere. Who does that? -Scott
7 years, 8 months ago (2011-07-18 21:20:48 UTC) #2
Nicolas Zea
Sync changes LGTM. Note that with autofill profiles they actually just added the guid for ...
7 years, 8 months ago (2011-07-18 21:36:33 UTC) #3
sky
One more question. How come we didn't have to do this with bookmarks? -Scott
7 years, 8 months ago (2011-07-18 21:45:08 UTC) #4
Nicolas Zea
Bookmarks was the first sync datatype and therefore took shortcuts that other datatypes can't employ. ...
7 years, 8 months ago (2011-07-18 21:49:24 UTC) #5
tim (not reviewing)
On 2011/07/18 21:49:24, nzea wrote: > Bookmarks was the first sync datatype and therefore took ...
7 years, 8 months ago (2011-07-18 22:01:12 UTC) #6
sky
Makes sense. Thanks for clarifying. -Scott On Mon, Jul 18, 2011 at 2:49 PM, Nicolas ...
7 years, 8 months ago (2011-07-18 22:06:46 UTC) #7
SteveT
Re: Who sets sync_guid TemplateURL: The sync_guid was to be set by the TemplateURLService sync ...
7 years, 8 months ago (2011-07-19 13:05:06 UTC) #8
sky
Just wanted to make sure I wasn't missing something. LGTM
7 years, 8 months ago (2011-07-19 15:01:33 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2011-07-19 15:58:40 UTC) #10
Can't apply patch for file
chrome/browser/sync/protocol/search_engine_specifics.proto.
While running patch -p0 --forward --force;
patching file chrome/browser/sync/protocol/search_engine_specifics.proto
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/sync/protocol/search_engine_specifics.proto.rej

Powered by Google App Engine
This is Rietveld 408576698