Revert "Revert "pylint: upgrade to 1.3.1""

Revert "Revert "pylint: upgrade to 1.3.1""

The reason cited for reverting was invalid, so reland the update.

BUG=chromium:431514
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293049

[vapier, 2014-11-20 22:01:43]

vapier@chromium.org changed reviewers:
+ agable@chromium.org, chrisha@chromium.org, kbr@chromium.org,
maruel@chromium.org, smut@google.com

[M-A Ruel, 2014-11-20 22:18:05]

lgtm?

Sent by touching glass
Le 2014-11-20 17:01, <vapier@chromium.org> a écrit :

> Reviewers: agable, chrisha, M-A Ruel, Ken Russell, smut,
>
> Description:
> Revert "Revert "pylint: upgrade to 1.3.1""
>
> The reason cited for reverting was invalid, so reland the update.
>
> BUG=chromium:431514
>
> Please review this at https://codereview.chromium.org/739393004/
>
> Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
>
> Affected files (+17402, -10007 lines):
>   D     third_party/logilab/astng/LICENSE.txt
>   D     third_party/logilab/astng/README.chromium
>   D     third_party/logilab/astng/__init__.py
>   D     third_party/logilab/astng/__pkginfo__.py
>   D     third_party/logilab/astng/as_string.py
>   D     third_party/logilab/astng/bases.py
>   D     third_party/logilab/astng/builder.py
>   D     third_party/logilab/astng/exceptions.py
>   D     third_party/logilab/astng/inference.py
>   D     third_party/logilab/astng/inspector.py
>   D     third_party/logilab/astng/manager.py
>   D     third_party/logilab/astng/mixins.py
>   D     third_party/logilab/astng/node_classes.py
>   D     third_party/logilab/astng/nodes.py
>   D     third_party/logilab/astng/protocols.py
>   D     third_party/logilab/astng/raw_building.py
>   D     third_party/logilab/astng/rebuilder.py
>   D     third_party/logilab/astng/scoped_nodes.py
>   D     third_party/logilab/astng/utils.py
>   A     third_party/logilab/astroid/LICENSE.txt
>   A     third_party/logilab/astroid/README.chromium
>   A     third_party/logilab/astroid/__init__.py
>   A     third_party/logilab/astroid/__pkginfo__.py
>   A     third_party/logilab/astroid/as_string.py
>   A     third_party/logilab/astroid/bases.py
>   A     third_party/logilab/astroid/brain/py2gi.py
>   A     third_party/logilab/astroid/brain/py2mechanize.py
>   A     third_party/logilab/astroid/brain/py2qt4.py
>   A     third_party/logilab/astroid/brain/py2stdlib.py
>   A     third_party/logilab/astroid/builder.py
>   A     third_party/logilab/astroid/exceptions.py
>   A     third_party/logilab/astroid/inference.py
>   A     third_party/logilab/astroid/inspector.py
>   A     third_party/logilab/astroid/manager.py
>   A     third_party/logilab/astroid/mixins.py
>   A     third_party/logilab/astroid/modutils.py
>   A     third_party/logilab/astroid/node_classes.py
>   A     third_party/logilab/astroid/nodes.py
>   A     third_party/logilab/astroid/protocols.py
>   A     third_party/logilab/astroid/raw_building.py
>   A     third_party/logilab/astroid/rebuilder.py
>   A     third_party/logilab/astroid/scoped_nodes.py
>   A     third_party/logilab/astroid/utils.py
>   M     third_party/logilab/common/LICENSE.txt
>   M     third_party/logilab/common/README.chromium
>   M     third_party/logilab/common/__init__.py
>   M     third_party/logilab/common/__pkginfo__.py
>   M     third_party/logilab/common/changelog.py
>   M     third_party/logilab/common/clcommands.py
>   M     third_party/logilab/common/cli.py
>   M     third_party/logilab/common/compat.py
>   M     third_party/logilab/common/configuration.py
>   M     third_party/logilab/common/corbautils.py
>   M     third_party/logilab/common/daemon.py
>   M     third_party/logilab/common/date.py
>   M     third_party/logilab/common/dbf.py
>   M     third_party/logilab/common/debugger.py
>   M     third_party/logilab/common/decorators.py
>   M     third_party/logilab/common/deprecation.py
>   M     third_party/logilab/common/fileutils.py
>   M     third_party/logilab/common/graph.py
>   D     third_party/logilab/common/hg.py
>   M     third_party/logilab/common/logging_ext.py
>   M     third_party/logilab/common/modutils.py
>   M     third_party/logilab/common/optik_ext.py
>   D     third_party/logilab/common/pdf_ext.py
>   M     third_party/logilab/common/pyro_ext.py
>   M     third_party/logilab/common/pytest.py
>   A     third_party/logilab/common/registry.py
>   M     third_party/logilab/common/shellutils.py
>   M     third_party/logilab/common/table.py
>   M     third_party/logilab/common/tasksqueue.py
>   M     third_party/logilab/common/testlib.py
>   M     third_party/logilab/common/textutils.py
>   M     third_party/logilab/common/umessage.py
>   M     third_party/logilab/common/ureports/__init__.py
>   M     third_party/logilab/common/ureports/docbook_writer.py
>   M     third_party/logilab/common/ureports/html_writer.py
>   M     third_party/logilab/common/ureports/nodes.py
>   M     third_party/logilab/common/ureports/text_writer.py
>   M     third_party/logilab/common/urllib2ext.py
>   M     third_party/logilab/common/visitor.py
>   M     third_party/pylint.py
>   M     third_party/pylint/README.chromium
>   M     third_party/pylint/__init__.py
>   A     third_party/pylint/__main__.py
>   M     third_party/pylint/__pkginfo__.py
>   M     third_party/pylint/checkers/__init__.py
>   M     third_party/pylint/checkers/base.py
>   M     third_party/pylint/checkers/classes.py
>   M     third_party/pylint/checkers/design_analysis.py
>   M     third_party/pylint/checkers/exceptions.py
>   M     third_party/pylint/checkers/format.py
>   M     third_party/pylint/checkers/imports.py
>   M     third_party/pylint/checkers/logging.py
>   M     third_party/pylint/checkers/misc.py
>   M     third_party/pylint/checkers/newstyle.py
>   M     third_party/pylint/checkers/raw_metrics.py
>   M     third_party/pylint/checkers/similar.py
>   A     third_party/pylint/checkers/stdlib.py
>   D     third_party/pylint/checkers/string_format.py
>   A     third_party/pylint/checkers/strings.py
>   M     third_party/pylint/checkers/typecheck.py
>   M     third_party/pylint/checkers/utils.py
>   M     third_party/pylint/checkers/variables.py
>   M     third_party/pylint/config.py
>   M     third_party/pylint/epylint.py
>   M     third_party/pylint/gui.py
>   M     third_party/pylint/interfaces.py
>   M     third_party/pylint/lint.py
>   M     third_party/pylint/pyreverse/diadefslib.py
>   M     third_party/pylint/pyreverse/diagrams.py
>   M     third_party/pylint/pyreverse/main.py
>   M     third_party/pylint/pyreverse/utils.py
>   M     third_party/pylint/pyreverse/writer.py
>   M     third_party/pylint/reporters/__init__.py
>   M     third_party/pylint/reporters/guireporter.py
>   M     third_party/pylint/reporters/html.py
>   M     third_party/pylint/reporters/text.py
>   A     third_party/pylint/testutils.py
>   M     third_party/pylint/utils.py
>   A     third_party/six/LICENSE.txt
>   A     third_party/six/README.chromium
>   A     third_party/six/__init__.py
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vapier, 2014-11-20 22:20:46]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-11-20 22:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/739393004/1

[commit-bot: I haz the power, 2014-11-20 22:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 22:21:21]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[smut, 2014-11-20 22:21:48]

On 2014/11/20 22:21:21, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Presumably you want to include the updated pylintrc in this CL.

[M-A Ruel, 2014-11-20 22:22:29]

lgtm

[vapier, 2014-11-20 22:22:42]

i thought my local rsync did that.  i'll upload a new one, thanks.

[vapier, 2014-11-20 22:25:04]

odd, my local repo shows pylintrc is updated:
$ svn st pylintrc 
M       pylintrc

and it has the extended list of disabled messages.  no idea why reitveld isn't
showing that.  maybe i need to svn commit it directly ?

[agable, 2014-11-20 22:30:20]

On 2014/11/20 at 22:25:04, vapier wrote:
> odd, my local repo shows pylintrc is updated:
> $ svn st pylintrc 
> M       pylintrc
> 
> and it has the extended list of disabled messages.  no idea why reitveld isn't
showing that.  maybe i need to svn commit it directly ?

Shouldn't need to svn commit directly. If this is giving you trouble I can
reland the original via Git. Should be clean.

[vapier, 2014-11-20 22:31:47]

ok, gcl is confused and still lists my old changeset even though it's already
been committed.  had to manually update files in .svn/gcl_info/changes/ so will
reupload.

[agable, 2014-11-20 22:33:08]

On 2014/11/20 at 22:31:47, vapier wrote:
> ok, gcl is confused and still lists my old changeset even though it's already
been committed.  had to manually update files in .svn/gcl_info/changes/ so will
reupload.

FWIW, using "fetch infra" or "fetch infra_internal" gets you a Git copy of
depot_tools :)

[vapier, 2014-11-20 22:34:46]

The CQ bit was checked by vapier@chromium.org

[commit-bot: I haz the power, 2014-11-20 22:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/739393004/10001

[commit-bot: I haz the power, 2014-11-20 22:41:11]

Committed patchset #2 (id:10001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293049

[vapier, 2014-12-03 00:18:03]

the issue with my checkout was i had some old insns i copied & pasted so my
'infra' section pointed to 'DEPS' which pulled in svn.  i hand updated it to
'.DEPS.git' and now i have a git repo.  whoo!