Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/logilab/common/ureports/nodes.py

Issue 739393004: Revert "Revert "pylint: upgrade to 1.3.1"" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/logilab/common/ureports/html_writer.py ('k') | third_party/logilab/common/ureports/text_writer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/logilab/common/ureports/nodes.py
===================================================================
--- third_party/logilab/common/ureports/nodes.py (revision 293047)
+++ third_party/logilab/common/ureports/nodes.py (working copy)
@@ -23,6 +23,8 @@
from logilab.common.tree import VNode
+from six import string_types
+
class BaseComponent(VNode):
"""base report component
@@ -79,7 +81,7 @@
super(Text, self).__init__(**kwargs)
#if isinstance(data, unicode):
# data = data.encode('ascii')
- assert isinstance(data, (str, unicode)), data.__class__
+ assert isinstance(data, string_types), data.__class__
self.escaped = escaped
self.data = data
« no previous file with comments | « third_party/logilab/common/ureports/html_writer.py ('k') | third_party/logilab/common/ureports/text_writer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698