Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: include/gpu/GrGpuResource.h

Issue 739383006: Making GrGpuResource::release public for special case in Blink (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrGpuResource.h
diff --git a/include/gpu/GrGpuResource.h b/include/gpu/GrGpuResource.h
index 659b7676164e06e56e85a0b679f23d29c6ab5c3a..61a03197ba6e19655f404c31908faf9487b80868 100644
--- a/include/gpu/GrGpuResource.h
+++ b/include/gpu/GrGpuResource.h
@@ -174,6 +174,15 @@ public:
inline CacheAccess cacheAccess();
inline const CacheAccess cacheAccess() const;
+ /**
+ * Frees the object in the underlying 3D API. Called by CacheAccess.
+ * In general this method should not be called outside of skia. It was
+ * made by public for a special case where it need to be called in Blink
+ * when a texture becomes unsafe to use after having been shared through
+ * a texture mailbox.
+ */
+ void release();
bsalomon 2014/12/10 20:35:02 Is it right to call release and not abandon in the
+
protected:
// This must be called by every GrGpuObject. It should be called once the object is fully
// initialized (i.e. not in a base class constructor).
@@ -206,10 +215,6 @@ protected:
void setScratchKey(const GrResourceKey& scratchKey);
private:
- /**
- * Frees the object in the underlying 3D API. Called by CacheAccess.
- */
- void release();
/**
* Removes references to objects in the underlying 3D API without freeing them.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698