Making GrGpuResource::release public for special case in Blink

include/gpu/GrGpuResource.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrGpuResource_DEFINED
 #define GrGpuResource_DEFINED
 
@@ skipping 156 matching lines @@
      */
     uint32_t getUniqueID() const { return fUniqueID; }
 
     /**
      * Internal-only helper class used for cache manipulations of the reosurce.
      */
     class CacheAccess;
     inline CacheAccess cacheAccess();
     inline const CacheAccess cacheAccess() const;
 
+    /**
+     * Frees the object in the underlying 3D API. Called by CacheAccess.
+     * In general this method should not be called outside of skia. It was
+     * made by public for a special case where it need to be called in Blink
+     * when a texture becomes unsafe to use after having been shared through
+     * a texture mailbox.
+     */
+    void release();

[bsalomon, 2014/12/10 20:35:02]

Is it right to call release and not abandon in the blink case? release() will
call glDeleteTextures whereas abandon() treats the ID as already freed.

+
 protected:
     // This must be called by every GrGpuObject. It should be called once the object is fully
     // initialized (i.e. not in a base class constructor).
     void registerWithCache();
 
     GrGpuResource(GrGpu*, bool isWrapped);
     virtual ~GrGpuResource();
 
     GrGpu* getGpu() const { return fGpu; }
 
@@ skipping 12 matching lines @@
      */
     void didChangeGpuMemorySize() const;
 
     /**
      * Optionally called by the GrGpuResource subclass if the resource can be used as scratch.
      * By default resources are not usable as scratch. This should only be called once.
      **/
     void setScratchKey(const GrResourceKey& scratchKey);
 
 private:
-    /**
-     * Frees the object in the underlying 3D API. Called by CacheAccess.
-     */
-    void release();
 
     /**
      * Removes references to objects in the underlying 3D API without freeing them. 
      * Called by CacheAccess.
      */
     void abandon();
 
     virtual size_t onGpuMemorySize() const = 0;
 
     // See comments in CacheAccess.
@@ skipping 43 matching lines @@
     mutable size_t          fGpuMemorySize;
 
     uint32_t                fFlags;
     const uint32_t          fUniqueID;
 
     typedef GrIORef<GrGpuResource> INHERITED;
     friend class GrIORef<GrGpuResource>; // to access notifyIsPurgable.
 };
 
 #endif