Making GrGpuResource::release public for special case in Blink

Making GrGpuResource::release public for special case in Blink

BUG=440462
Committed: https://skia.googlesource.com/skia/+/436293a3308d58ce494d9667bd13428dd6e35236

[Justin Novosad, 2014-12-10 20:13:33]

junov@chromium.org changed reviewers:
+ bsalomon@google.com

[Justin Novosad, 2014-12-10 20:13:33]

PTAL

[bsalomon, 2014-12-10 20:35:02]

https://codereview.chromium.org/739383006/diff/1/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/739383006/diff/1/include/gpu/GrGpuResource.h#...
include/gpu/GrGpuResource.h:184: void release();
Is it right to call release and not abandon in the blink case? release() will
call glDeleteTextures whereas abandon() treats the ID as already freed.

[Justin Novosad, 2014-12-11 05:43:01]

On 2014/12/10 20:35:02, bsalomon wrote:
> https://codereview.chromium.org/739383006/diff/1/include/gpu/GrGpuResource.h
> File include/gpu/GrGpuResource.h (right):
> 
>
https://codereview.chromium.org/739383006/diff/1/include/gpu/GrGpuResource.h#...
> include/gpu/GrGpuResource.h:184: void release();
> Is it right to call release and not abandon in the blink case? release() will
> call glDeleteTextures whereas abandon() treats the ID as already freed.

Right. Since I first uploaded this patch, piman updated the bug with more info.
Clarifying that it would be safe to just abandon. But the plot thickens...  It
appears that in cases where textures are recycled via the scratch pool, I should
use the same mailbox as the previous time the texture was used, and not
regenerate a new one to avoid leaking mailbox objects.  The simplest solution I
see for this is to add a mailbox field to GrTexture, or if we don't want skia to
be aware of mailboxes, a custom data field could do the trick. Basically, what I
need is a way of determining whether a recycled GrTexture is already bound to a
mailbox, and what the name of that mailbox is. I thought of just keeping a
texture ID to mailbox map on the blink side, but that is not good enough because
glGenTextures can return the ID of a previously deleted texture.  WDYT?

[Justin Novosad, 2014-12-11 17:51:44]

New patch.

[bsalomon, 2014-12-11 18:22:20]

On 2014/12/11 18:18:32, bsalomon wrote:

lgtm, I meant.

[Justin Novosad, 2014-12-11 18:23:22]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2014-12-11 18:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/739383006/40001

[commit-bot: I haz the power, 2014-12-11 18:32:37]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/436293a3308d58ce494d9667bd13428dd6e35236