Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 739383004: Add bypass_platform_checks option to java_library/binary (Closed)

Created:
6 years, 1 month ago by cjhopman
Modified:
6 years, 1 month ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add bypass_platform_checks option to java_library/binary This allows a target to disable checks that prevent a java library from depending on an android_library. This is required for the current way that we build java unittests. Also, remove provides_android_platform option. This was planned to support unit tests, but it doesn't really work (at the top-level we want to depend on both targets that require Android and ones that don't support Android). Also fixes some minor target definition issues. TBR=cpu BUG=359249 Committed: https://crrev.com/7aac92d873502f8a9676bf6b3a95cdfa8cce82c5 Cr-Commit-Position: refs/heads/master@{#305326}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M build/android/gyp/write_build_config.py View 1 2 chunks +5 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 4 chunks +6 lines, -7 lines 0 comments Download
M build/config/android/rules.gni View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/jsr-305/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libaddressinput/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
cjhopman
newt: *
6 years, 1 month ago (2014-11-21 02:46:55 UTC) #2
newt (away)
s/provides_android_platform/requires_android_platform in the commit message lgtm https://codereview.chromium.org/739383004/diff/1/build/android/gyp/write_build_config.py File build/android/gyp/write_build_config.py (right): https://codereview.chromium.org/739383004/diff/1/build/android/gyp/write_build_config.py#newcode155 build/android/gyp/write_build_config.py:155: deps_info['requires_android'] = options.requires_android ...
6 years, 1 month ago (2014-11-21 19:38:46 UTC) #3
cjhopman
cpu: TBRed for third_party changes https://codereview.chromium.org/739383004/diff/1/build/android/gyp/write_build_config.py File build/android/gyp/write_build_config.py (right): https://codereview.chromium.org/739383004/diff/1/build/android/gyp/write_build_config.py#newcode155 build/android/gyp/write_build_config.py:155: deps_info['requires_android'] = options.requires_android On ...
6 years, 1 month ago (2014-11-21 23:11:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739383004/20001
6 years, 1 month ago (2014-11-21 23:12:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-22 00:10:54 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 00:11:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7aac92d873502f8a9676bf6b3a95cdfa8cce82c5
Cr-Commit-Position: refs/heads/master@{#305326}

Powered by Google App Engine
This is Rietveld 408576698