Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5209)

Unified Diff: build/config/android/rules.gni

Issue 739383004: Add bypass_platform_checks option to java_library/binary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | third_party/jsr-305/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 3f54c43a73685b8401cf47432c2c550f9f0acecf..938a09005afdfc44727f67b9fdfe9976aa78d8f2 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -655,6 +655,10 @@ template("java_strings_grd_prebuilt") {
# srcjars: List of srcjars to be included in this library, together with the
# ones obtained from srcjar_deps.
#
+# bypass_platform_checks: Disables checks about cross-platform (Java/Android)
+# dependencies for this target. This will allow depending on an
+# android_library target, for example.
+#
# chromium_code: If true, extra analysis warning/errors will be enabled.
#
# datadeps, testonly
@@ -676,6 +680,7 @@ template("java_binary") {
if (defined(invoker.java_files)) { java_files = invoker.java_files }
if (defined(invoker.srcjar_deps)) { srcjar_deps = invoker.srcjar_deps }
if (defined(invoker.srcjars)) { srcjars = invoker.srcjars }
+ if (defined(invoker.bypass_platform_checks)) { bypass_platform_checks = invoker.bypass_platform_checks }
if (defined(invoker.testonly)) { testonly = invoker.testonly }
main_class = invoker.main_class
@@ -709,10 +714,9 @@ template("java_binary") {
# supports_android: If true, Android targets (android_library, android_apk)
# may depend on this target. Note: if true, this target must only use the
# subset of Java available on Android.
-# requires_android_platform: If true, this library may depend on
-# android-specific targets. If this is the case, there should be some
-# android-platform-like implementation available at runtime (Android,
-# robolectric, etc).
+# bypass_platform_checks: Disables checks about cross-platform (Java/Android)
+# dependencies for this target. This will allow depending on an
+# android_library target, for example.
#
# datadeps, testonly
#
@@ -745,17 +749,13 @@ template("java_library") {
if (defined(invoker.proguard_preprocess)) { proguard_preprocess = invoker.proguard_preprocess }
if (defined(invoker.srcjar_deps)) { srcjar_deps = invoker.srcjar_deps }
if (defined(invoker.srcjars)) { srcjars = invoker.srcjars }
+ if (defined(invoker.bypass_platform_checks)) { bypass_platform_checks = invoker.bypass_platform_checks }
if (defined(invoker.testonly)) { testonly = invoker.testonly }
if (defined(invoker.jar_path)) { jar_path = invoker.jar_path }
if (defined(invoker.supports_android) && invoker.supports_android) {
supports_android = true
}
- if (defined(invoker.requires_android_platform)
- && invoker.requires_android_platform) {
- supports_android = true
- requires_android = true
- }
}
}
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | third_party/jsr-305/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698