Don't drop messages/events send to a service worker that is stopping.

Don't drop messages/events send to a service worker that is stopping.

Currently ServiceWorkerVersion drops any messages that are sent while
the service worker is in STOPPING state. In particular messages send
to the service worker using postMessage are never delivered if the
service worker is currently in the STOPPING state.
The same situation will happen if any other subsystem happens to try
to deliver an event to a service worker while the service worker is
shutting down. The event delivery will fail with a
"SERVICE_WORKER_ERROR_START_WORKER_FAILED" error.

This fixes this by restarting the service worker as soon as it has
finished stopping if some event or message is attempted to be delivered
while the service worker is stopping.

BUG=433439
Committed: https://crrev.com/b8f566900faccfe07b4e6a2f13629ec0554ca553
Cr-Commit-Position: refs/heads/master@{#306588}

[Marijn Kruisselbrink, 2014-11-20 21:55:53]

mek@chromium.org changed reviewers:
+ dominicc@chromium.org, falken@chromium.org

[Marijn Kruisselbrink, 2014-11-20 21:55:53]

As I mentioned in the bug report for this, I have no idea if this is the right
fix and/or what unintended consequences this change might have, so if anybody
has a better idea how to fix this (or wants to fix this themselves) by all means
let me know.

[falken, 2014-11-25 15:46:04]

I think this lgtm. Can you revise the CL description a bit to explain why the
change is needed (like it's described in the bug)?

Thanks for the fix!

https://codereview.chromium.org/739383002/diff/20001/content/browser/service_...
File content/browser/service_worker/service_worker_version_unittest.cc (right):

https://codereview.chromium.org/739383002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_version_unittest.cc:275: //
SendMessage should return SERVICE_WORKER_OK error since the worker should
nit: remove "error"

[Marijn Kruisselbrink, 2014-12-03 11:38:05]

On 2014/11/25 15:46:04, falken wrote:
> I think this lgtm. Can you revise the CL description a bit to explain why the
> change is needed (like it's described in the bug)?
Done

> Thanks for the fix!
> 
>
https://codereview.chromium.org/739383002/diff/20001/content/browser/service_...
> File content/browser/service_worker/service_worker_version_unittest.cc
(right):
> 
>
https://codereview.chromium.org/739383002/diff/20001/content/browser/service_...
> content/browser/service_worker/service_worker_version_unittest.cc:275: //
> SendMessage should return SERVICE_WORKER_OK error since the worker should
> nit: remove "error"
Done

[Marijn Kruisselbrink, 2014-12-03 11:38:10]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-12-03 11:38:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/739383002/60001

[commit-bot: I haz the power, 2014-12-03 11:40:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-03 11:41:36]

Patchset 4 (id:??) landed as
https://crrev.com/b8f566900faccfe07b4e6a2f13629ec0554ca553
Cr-Commit-Position: refs/heads/master@{#306588}