content/browser/service_worker/embedded_worker_instance.cc - Issue 739383002: Don't drop messages/events send to a service worker that is stopping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 739383002: Don't drop messages/events send to a service worker that is stopping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@termnate_sw

Patch Set: address nit Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/browser/service_worker/service_worker_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance.cc

diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc

index 439be29b8836d97d40a5e046380d2d4be60c921f..bd5c9cfe0f4aaf96f7b24e384ac1b6fb9b375e8b 100644

--- a/content/browser/service_worker/embedded_worker_instance.cc

+++ b/content/browser/service_worker/embedded_worker_instance.cc

@@ -291,12 +291,13 @@ void EmbeddedWorkerInstance::OnStopped() {

NotifyWorkerDestroyed(process_id_, worker_devtools_agent_route_id_);

if (context_)

context_->process_manager()->ReleaseWorkerProcess(embedded_worker_id_);

+ Status old_status = status_;

status_ = STOPPED;

process_id_ = -1;

thread_id_ = -1;

worker_devtools_agent_route_id_ = MSG_ROUTING_NONE;

start_callback_.Reset();

- FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped());

+ FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped(old_status));

}

void EmbeddedWorkerInstance::OnPausedAfterDownload() {