Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739193002: Un-deprecate Attr.nodeValue and Attr.textContent (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Un-deprecate Attr.nodeValue and Attr.textContent These are both back in the DOM Standard: https://dom.spec.whatwg.org/#attr Spec bugs: https://www.w3.org/Bugs/Public/show_bug.cgi?id=26596 https://www.w3.org/Bugs/Public/show_bug.cgi?id=27363 These were deprecated in Blink before any of this happened: https://codereview.chromium.org/253843002 It turns out that the usage of nodeValue in particular is far too high: https://www.chromestatus.com/metrics/feature/timeline/popularity/348 https://www.chromestatus.com/metrics/feature/timeline/popularity/349 We're probably stuck with both forever, but they're trivial to support. Keep the counters just to see if things change over time. BUG=305105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -59 lines) Patch
M LayoutTests/dom/html/level1/core/hc_attrappendchild1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrappendchild6-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrclonenode1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrcreatetextnode2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attreffectivevalue-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrnormalize-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrremovechild1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrreplacechild1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrreplacechild2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrsetvalue1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_attrsetvalue2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_documentcreateattribute-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_namednodemapsetnameditemreturnvalue-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_namednodemapsetnameditemthatexists-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/html/level1/core/hc_nodeattributenodevalue-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrappendchild6-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrclonenode1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrcreatetextnode-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrcreatetextnode2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attreffectivevalue-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrinsertbefore4-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrnormalize-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrremovechild1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrreplacechild1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrreplacechild2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrsetvalue1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_attrsetvalue2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_documentcreateattribute-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_namednodemapsetnameditemreturnvalue-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_namednodemapsetnameditemthatexists-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level1/core/hc_nodeattributenodevalue-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode01-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode02-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/documentadoptnode21-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent06-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent07-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent05-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/jquery/attributes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Attr.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL I can send a PSA for this one if you like too, but the ...
6 years, 1 month ago (2014-11-19 14:19:18 UTC) #2
Mike West
:( LGTM.
6 years, 1 month ago (2014-11-19 16:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739193002/1
6 years, 1 month ago (2014-11-19 16:09:08 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 16:37:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185606

Powered by Google App Engine
This is Rietveld 408576698