Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 739173002: Remove dependencies of ResourceRequestAllowedNotifier on chrome/ (Closed)

Created:
6 years, 1 month ago by droger
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove dependencies of ResourceRequestAllowedNotifier on chrome/ This CL prepares the componentization of ResourceRequestAllowedNotifier and EulaAcceptedNotifier. Some unused dependencies are cleaned up, and the dependency on BrowserProcess is removed by passing the PrefService in the constructors instead. TBR=achuith Committed: https://crrev.com/f4455485213d6000fd11773664478bd301ba3dd3 Cr-Commit-Position: refs/heads/master@{#305190}

Patch Set 1 : cleanup unused dependencies #

Patch Set 2 : Remove dependency on g_browser_process #

Patch Set 3 : Rebase and cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M chrome/browser/metrics/variations/variations_service.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 1 6 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_service.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/web_resource/eula_accepted_notifier.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/eula_accepted_notifier.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/web_resource/eula_accepted_notifier_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier_test_util.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier_test_util.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
droger
6 years, 1 month ago (2014-11-20 14:22:56 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 1 month ago (2014-11-20 17:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739173002/40001
6 years, 1 month ago (2014-11-21 09:10:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25807)
6 years, 1 month ago (2014-11-21 09:15:12 UTC) #7
droger
TBR=achuith for trivial change in web_resource_service.cc
6 years, 1 month ago (2014-11-21 09:20:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739173002/40001
6 years, 1 month ago (2014-11-21 09:21:13 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-21 09:50:31 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 09:51:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4455485213d6000fd11773664478bd301ba3dd3
Cr-Commit-Position: refs/heads/master@{#305190}

Powered by Google App Engine
This is Rietveld 408576698