Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1957)

Unified Diff: chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc

Issue 739173002: Remove dependencies of ResourceRequestAllowedNotifier on chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
diff --git a/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc b/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
index fbda9932fea0886bd1b5cc42c2548e9a28496a7c..68f1ced7c0f9261fb00808a529ea3ded7e76269b 100644
--- a/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
+++ b/chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc
@@ -3,12 +3,8 @@
// found in the LICENSE file.
#include "base/prefs/testing_pref_service.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/web_resource/eula_accepted_notifier.h"
#include "chrome/browser/web_resource/resource_request_allowed_notifier_test_util.h"
-#include "chrome/test/base/testing_browser_process.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
// Override NetworkChangeNotifier to simulate connection type changes for tests.
@@ -75,9 +71,9 @@ class ResourceRequestAllowedNotifierTest
public ResourceRequestAllowedNotifier::Observer {
public:
ResourceRequestAllowedNotifierTest()
- : ui_thread(content::BrowserThread::UI, &message_loop),
- eula_notifier_(new TestEulaAcceptedNotifier),
- was_notified_(false) {
+ : resource_request_allowed_notifier_(&prefs_),
+ eula_notifier_(new TestEulaAcceptedNotifier),
+ was_notified_(false) {
resource_request_allowed_notifier_.InitWithEulaAcceptNotifier(
this, scoped_ptr<EulaAcceptedNotifier>(eula_notifier_));
}
@@ -139,8 +135,8 @@ class ResourceRequestAllowedNotifierTest
private:
base::MessageLoopForUI message_loop;
- content::TestBrowserThread ui_thread;
TestNetworkChangeNotifier network_notifier;
+ TestingPrefServiceSimple prefs_;
TestRequestAllowedNotifier resource_request_allowed_notifier_;
TestEulaAcceptedNotifier* eula_notifier_; // Weak, owned by RRAN.
bool was_notified_;

Powered by Google App Engine
This is Rietveld 408576698