Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 739133004: Small cleanups after GrDrawState/GrOptDrawState base class elimination. (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Small cleanups after GrDrawState/GrOptDrawState base class elimination. Committed: https://skia.googlesource.com/skia/+/04ddf89627077ea8f2b447e7cd5e902956341a32

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : fix flags #

Patch Set 4 : more cleanup #

Patch Set 5 : remove branches #

Patch Set 6 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -201 lines) Patch
M src/gpu/GrDrawState.h View 1 2 3 4 5 8 chunks +19 lines, -57 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 3 6 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 2 3 4 5 6 chunks +20 lines, -95 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 9 chunks +37 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
6 years, 1 month ago (2014-11-19 19:51:12 UTC) #2
egdaniel
lgtm
6 years, 1 month ago (2014-11-19 20:16:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739133004/80001
6 years, 1 month ago (2014-11-19 20:19:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/761) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/750)
6 years, 1 month ago (2014-11-19 20:20:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739133004/100001
6 years, 1 month ago (2014-11-19 20:27:17 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 20:36:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/04ddf89627077ea8f2b447e7cd5e902956341a32

Powered by Google App Engine
This is Rietveld 408576698