Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 739133003: Revert of Accept invalid chrome-extension:// and chrome:// CSP tokens (Closed)

Created:
6 years, 1 month ago by robwu
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Accept invalid chrome-extension:// and chrome:// CSP tokens (patchset #3 id:80001 of https://codereview.chromium.org/722233004/) Reason for revert: Need some extra comments before relanding Original issue's description: > Accept invalid chrome-extension:// and chrome:// CSP tokens > > Do not refuse to load the extension when the CSP contains > "chrome-extension://", because there are some extensions in the wild > that contains this token in the CSP. It is safe to accept this token > because the invalid CSP token is ignored by Blink (together with an > error message in the console, so the developer can fix the problem if > they bother to look at the console). > > BUG=432227 > TBR=kalman@chromium.org > > Committed: https://crrev.com/67244e678279741947c09ba2ab18fbfec1707a97 > Cr-Commit-Position: refs/heads/master@{#304799} TBR=kalman@chromium.org NOTREECHECKS=true NOTRY=true BUG=432227 Committed: https://crrev.com/cbc409a84a88dd002c37f113eabb74468448d00d Cr-Commit-Position: refs/heads/master@{#304832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M extensions/common/csp_validator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/common/csp_validator_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robwu
Created Revert of Accept invalid chrome-extension:// and chrome:// CSP tokens
6 years, 1 month ago (2014-11-19 17:38:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/739133003/1
6 years, 1 month ago (2014-11-19 17:38:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 17:40:04 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 17:41:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbc409a84a88dd002c37f113eabb74468448d00d
Cr-Commit-Position: refs/heads/master@{#304832}

Powered by Google App Engine
This is Rietveld 408576698