extensions/common/csp_validator_unittest.cc - Issue 739133003: Revert of Accept invalid chrome-extension:// and chrome:// CSP tokens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/csp_validator_unittest.cc

Issue 739133003: Revert of Accept invalid chrome-extension:// and chrome:// CSP tokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/csp_validator_unittest.cc

diff --git a/extensions/common/csp_validator_unittest.cc b/extensions/common/csp_validator_unittest.cc

index 741007fdbbd6584d525909e9858678227be77986..9778a5a22d671a41f769b9a9cbedebe9a2f7b2a0 100644

--- a/extensions/common/csp_validator_unittest.cc

+++ b/extensions/common/csp_validator_unittest.cc

@@ -98,7 +98,7 @@

"default-src 'self' *:*/", Manifest::TYPE_EXTENSION));

EXPECT_FALSE(ContentSecurityPolicyIsSecure(

"default-src 'self' *:*/path", Manifest::TYPE_EXTENSION));

- EXPECT_TRUE(ContentSecurityPolicyIsSecure(

+ EXPECT_FALSE(ContentSecurityPolicyIsSecure(

"default-src 'self' https://", Manifest::TYPE_EXTENSION));

EXPECT_FALSE(ContentSecurityPolicyIsSecure(

"default-src 'self' https://*:*", Manifest::TYPE_EXTENSION));

@@ -167,8 +167,6 @@

"default-src 'self' https://*.googleapis.com", Manifest::TYPE_EXTENSION));

EXPECT_TRUE(ContentSecurityPolicyIsSecure(

"default-src 'self' https://x.googleapis.com", Manifest::TYPE_EXTENSION));

- EXPECT_TRUE(ContentSecurityPolicyIsSecure(

- "default-src 'self' chrome-extension://", Manifest::TYPE_EXTENSION));

}

TEST(ExtensionCSPValidator, IsSandboxed) {

« no previous file with comments | « extensions/common/csp_validator.cc ('k') | no next file » | no next file with comments »