Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 738973005: Measure video stats for WebRTC calls to ensure video works. (Closed)

Created:
6 years, 1 month ago by phoglund_chromium
Modified:
6 years, 1 month ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Measure video stats for WebRTC calls to ensure video works. This will count the number of dropped frames and the number of decoded frames. This provides a reasonable guarantee that the video pipeline is working. The next step would be to look at the actual pixels in the video. BUG=434701 Committed: https://crrev.com/56c60209b09297951f2321d5b5818e1a97dca465 Cr-Commit-Position: refs/heads/master@{#305030}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Now excluding metrics that aren't hooked up for WebRTC video tags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M tools/perf/measurements/webrtc.py View 1 4 chunks +13 lines, -3 lines 0 comments Download
M tools/perf/metrics/media.py View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
phoglund_chromium
6 years, 1 month ago (2014-11-19 13:41:25 UTC) #2
qyearsley
lgtm https://codereview.chromium.org/738973005/diff/1/tools/perf/measurements/webrtc.py File tools/perf/measurements/webrtc.py (right): https://codereview.chromium.org/738973005/diff/1/tools/perf/measurements/webrtc.py#newcode61 tools/perf/measurements/webrtc.py:61: self._media_metric.AddResults(tab, results) I'm wondering whether there's any particular ...
6 years, 1 month ago (2014-11-19 21:15:33 UTC) #3
phoglund_chromium
Actually, Quinten, please take another look. I realized I was adding decoded_*_bytes parameters, but those ...
6 years, 1 month ago (2014-11-20 09:26:46 UTC) #4
qyearsley
lgtm still :-)
6 years, 1 month ago (2014-11-20 15:49:46 UTC) #5
phoglund_chromium
On 2014/11/20 15:49:46, qyearsley wrote: > lgtm still :-) Thank you sir. Committing.
6 years, 1 month ago (2014-11-20 15:56:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738973005/20001
6 years, 1 month ago (2014-11-20 15:57:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 17:39:56 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:40:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56c60209b09297951f2321d5b5818e1a97dca465
Cr-Commit-Position: refs/heads/master@{#305030}

Powered by Google App Engine
This is Rietveld 408576698