Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: tools/perf/measurements/webrtc.py

Issue 738973005: Measure video stats for WebRTC calls to ensure video works. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import cpu 5 from metrics import cpu
6 from metrics import media
6 from metrics import memory 7 from metrics import memory
7 from metrics import power 8 from metrics import power
8 from metrics import webrtc_stats 9 from metrics import webrtc_stats
9 from telemetry.page import page_test 10 from telemetry.page import page_test
10 11
11 12
12 class WebRTC(page_test.PageTest): 13 class WebRTC(page_test.PageTest):
13 """Gathers WebRTC-related metrics on a page set.""" 14 """Gathers WebRTC-related metrics on a page set."""
14 15
15 def __init__(self): 16 def __init__(self):
16 super(WebRTC, self).__init__('RunPageInteractions') 17 super(WebRTC, self).__init__('RunPageInteractions')
17 self._cpu_metric = None 18 self._cpu_metric = None
19 self._media_metric = None
18 self._memory_metric = None 20 self._memory_metric = None
19 self._power_metric = None 21 self._power_metric = None
20 self._webrtc_stats_metric = None 22 self._webrtc_stats_metric = None
21 23
22 def WillStartBrowser(self, platform): 24 def WillStartBrowser(self, platform):
23 self._power_metric = power.PowerMetric(platform) 25 self._power_metric = power.PowerMetric(platform)
24 26
25 def DidStartBrowser(self, browser): 27 def DidStartBrowser(self, browser):
26 self._cpu_metric = cpu.CpuMetric(browser) 28 self._cpu_metric = cpu.CpuMetric(browser)
27 self._memory_metric = memory.MemoryMetric(browser) 29 self._memory_metric = memory.MemoryMetric(browser)
28 self._webrtc_stats_metric = webrtc_stats.WebRtcStatisticsMetric() 30 self._webrtc_stats_metric = webrtc_stats.WebRtcStatisticsMetric()
29 31
30 def DidNavigateToPage(self, page, tab): 32 def DidNavigateToPage(self, page, tab):
31 self._cpu_metric.Start(page, tab) 33 self._cpu_metric.Start(page, tab)
34 self._media_metric = media.MediaMetric(tab)
35 self._media_metric.Start(page, tab)
32 self._memory_metric.Start(page, tab) 36 self._memory_metric.Start(page, tab)
33 self._power_metric.Start(page, tab) 37 self._power_metric.Start(page, tab)
34 self._webrtc_stats_metric.Start(page, tab) 38 self._webrtc_stats_metric.Start(page, tab)
35 39
36 def CustomizeBrowserOptions(self, options): 40 def CustomizeBrowserOptions(self, options):
37 memory.MemoryMetric.CustomizeBrowserOptions(options) 41 memory.MemoryMetric.CustomizeBrowserOptions(options)
38 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream') 42 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
39 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream') 43 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
40 power.PowerMetric.CustomizeBrowserOptions(options) 44 power.PowerMetric.CustomizeBrowserOptions(options)
41 45
42 def ValidateAndMeasurePage(self, page, tab, results): 46 def ValidateAndMeasurePage(self, page, tab, results):
43 """Measure the page's performance.""" 47 """Measure the page's performance."""
44 self._memory_metric.Stop(page, tab) 48 self._memory_metric.Stop(page, tab)
45 self._memory_metric.AddResults(tab, results) 49 self._memory_metric.AddResults(tab, results)
46 50
47 self._cpu_metric.Stop(page, tab) 51 self._cpu_metric.Stop(page, tab)
48 self._cpu_metric.AddResults(tab, results) 52 self._cpu_metric.AddResults(tab, results)
49 53
50 self._power_metric.Stop(page, tab) 54 self._power_metric.Stop(page, tab)
51 self._power_metric.AddResults(tab, results) 55 self._power_metric.AddResults(tab, results)
52 56
53 self._webrtc_stats_metric.Stop(page, tab) 57 self._webrtc_stats_metric.Stop(page, tab)
54 self._webrtc_stats_metric.AddResults(tab, results) 58 self._webrtc_stats_metric.AddResults(tab, results)
59
60 self._media_metric.Stop(page, tab)
61 self._media_metric.AddResults(tab, results)
qyearsley 2014/11/19 21:15:33 I'm wondering whether there's any particular reaso
phoglund_chromium 2014/11/20 09:26:46 Nope, none at all. Actually I should move it sorte
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698