Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 738943004: Initialize struct flock for AIX with O_LARGEFILE used by Python. (Closed)

Created:
6 years, 1 month ago by David Edelsohn
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Initialize struct flock for AIX with O_LARGEFILE used by Python. gyp issue 440 Python on AIX is compiled with LARGEFILE support. gyp flock_tool must use the appropriate stucture member definitions to properly initialize the structure. BUG= r2008

Patch Set 1 #

Total comments: 1

Patch Set 2 : AIX LARGEFILE support comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M pylib/gyp/flock_tool.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
David Edelsohn
Hi, Nico This is the new issue created for the AIX flock LARGEFILE initialization bug. ...
6 years, 1 month ago (2014-11-21 15:56:34 UTC) #2
Nico
lgtm with a comment: https://codereview.chromium.org/738943004/diff/1/pylib/gyp/flock_tool.py File pylib/gyp/flock_tool.py (right): https://codereview.chromium.org/738943004/diff/1/pylib/gyp/flock_tool.py#newcode43 pylib/gyp/flock_tool.py:43: if sys.platform.startswith('aix'): Please add a ...
6 years, 1 month ago (2014-11-21 17:32:14 UTC) #3
David Edelsohn
On 2014/11/21 17:32:14, Nico wrote: > lgtm with a comment: > > https://codereview.chromium.org/738943004/diff/1/pylib/gyp/flock_tool.py > File ...
6 years, 1 month ago (2014-11-21 23:45:29 UTC) #4
Nico
lgtm, I'll land Thanks!
6 years, 1 month ago (2014-11-22 00:06:55 UTC) #5
Nico
6 years, 1 month ago (2014-11-22 00:08:08 UTC) #6
gyp r2008

Powered by Google App Engine
This is Rietveld 408576698