Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738853002: [turbofan]: delay ssa deconstruction in register allocator (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan]: delay ssa deconstruction in register allocator BUG= Committed: https://chromium.googlesource.com/v8/v8/+/007bd2113b0a4c70df5774b0c1fb027fa72423b8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -162 lines) Patch
M src/compiler/instruction.h View 1 2 3 1 chunk +30 lines, -4 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 5 chunks +8 lines, -20 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 8 chunks +61 lines, -104 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 1 chunk +8 lines, -12 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
lgtm with nits. https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode994 src/compiler/register-allocator.cc:994: // TODO(dcarney): this in no longer ...
6 years, 1 month ago (2014-11-19 15:43:04 UTC) #2
dcarney
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc File src/compiler/register-allocator.cc (right): https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode994 src/compiler/register-allocator.cc:994: // TODO(dcarney): this in no longer reachable. On 2014/11/19 ...
6 years, 1 month ago (2014-11-19 15:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738853002/80001
6 years, 1 month ago (2014-11-19 15:56:39 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 16:23:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001)

Powered by Google App Engine
This is Rietveld 408576698