Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 738673003: Update HTML5 fullscreen/pointerlock documentation re: ESC handling. (Closed)

Created:
6 years, 1 month ago by scheib
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Update HTML5 fullscreen/pointerlock documentation re: ESC handling. Indicate the special handling of ESC key and the permissions required to enter fullscreen/pointerlock and override ESC. Committed: https://crrev.com/afbe64d30ca8dd895dc0afcf507bf48749c69208 Cr-Commit-Position: refs/heads/master@{#305128}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Pointer lock permission stated (but not making the mistake of pointer lock ESC handling differing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/common/extensions/docs/templates/articles/api_other.html View 1 2 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
scheib
6 years, 1 month ago (2014-11-18 17:02:03 UTC) #2
benwells
https://codereview.chromium.org/738673003/diff/1/chrome/common/extensions/docs/templates/articles/api_other.html File chrome/common/extensions/docs/templates/articles/api_other.html (right): https://codereview.chromium.org/738673003/diff/1/chrome/common/extensions/docs/templates/articles/api_other.html#newcode71 chrome/common/extensions/docs/templates/articles/api_other.html:71: requiring a user gesture, Could we also update this ...
6 years, 1 month ago (2014-11-20 23:21:00 UTC) #4
scheib
https://codereview.chromium.org/738673003/diff/1/chrome/common/extensions/docs/templates/articles/api_other.html File chrome/common/extensions/docs/templates/articles/api_other.html (right): https://codereview.chromium.org/738673003/diff/1/chrome/common/extensions/docs/templates/articles/api_other.html#newcode71 chrome/common/extensions/docs/templates/articles/api_other.html:71: requiring a user gesture, On 2014/11/20 23:21:00, benwells wrote: ...
6 years, 1 month ago (2014-11-20 23:32:38 UTC) #5
scheib
I've corrected a mistake in patch2, pointer lock doesn't have the same ESC override permission ...
6 years, 1 month ago (2014-11-20 23:46:41 UTC) #6
benwells
lgtm
6 years, 1 month ago (2014-11-20 23:54:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738673003/40001
6 years, 1 month ago (2014-11-21 00:01:51 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-21 00:54:09 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:55:21 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/afbe64d30ca8dd895dc0afcf507bf48749c69208
Cr-Commit-Position: refs/heads/master@{#305128}

Powered by Google App Engine
This is Rietveld 408576698