Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2027)

Unified Diff: chrome/common/extensions/docs/templates/articles/api_other.html

Issue 738673003: Update HTML5 fullscreen/pointerlock documentation re: ESC handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Pointer lock permission stated (but not making the mistake of pointer lock ESC handling differing) Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/templates/articles/api_other.html
diff --git a/chrome/common/extensions/docs/templates/articles/api_other.html b/chrome/common/extensions/docs/templates/articles/api_other.html
index c70c2c18ae85bd596a21231c32ae679bcafcb5a6..f59f41797b9462f3725934d1e59f592a96d8791f 100644
--- a/chrome/common/extensions/docs/templates/articles/api_other.html
+++ b/chrome/common/extensions/docs/templates/articles/api_other.html
@@ -46,9 +46,14 @@ E.g. window.open(someUrl). --></dd>
<ul>
<li>In Chrome Apps, fullscreen is entered without
prompting the user or providing exit instructions.
- Also, there is no default exit behavior. In normal webpages,
- the browser intercepts the ESC key to exit fullscreen.
- This behavior is not present in Chrome Apps.</li>
+ HTML5 fullscreen requires the <code>app.window.fullscreen</code>
+ permission in the manifest.
+ In normal webpages, the browser intercepts the ESC key to exit
+ pointer lock ensuring a consistent escape method for users.
+ That is also the behavior in Chrome Apps unless the
+ <code>app.window.fullscreen.overrideEsc</code>
+ permission is used to enable the app to call
+ <code>preventDefault</code> on keydown and keyup events.</li>
</ul>
</li>
{{/is_apps}}
@@ -65,6 +70,8 @@ E.g. window.open(someUrl). --></dd>
<li>In Chrome Apps, pointer lock is entered without
requiring a user gesture,
prompting the user, or providing exit instructions.
+ Pointer lock requires the <code>pointerlock</code>
+ permission in the manifest.
Also, there is no default exit behavior. In normal webpages,
the browser intercepts the ESC key to exit pointer lock.
This behavior is not present in Chrome Apps.</li>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698