Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 7384008: Revert 92668 - Remove more unnecessary ChromeURLRequestContext members. (Closed)

Created:
9 years, 5 months ago by willchan no longer on Chromium
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 92668 - Remove more unnecessary ChromeURLRequestContext members. ProfileIOData is now always deleted on the IO thread. Replaces a use of ChromeURLRequestContextGetter with a ChromeURLDataManagerBackend getter callback. Also gets rid of ExtensionInfoMap from ChromeURLRequestContext by directly passing it into the places that need it. Gets rid of the HTML5 storage objects from ChromeURLRequestContext too. Adds a workaround for TranslateManager's Profile::GetDefaultRequestContext() use, since after this refactoring (by not requiring ChromeURLRequestContextGetter for ChromeURLDataManagerBackend), it prevents having to initialize the ChromeURLRequestContextGetter in most tests since they don't actually use it. This means |default_request_context_| doesn't always get initialized in BrowserMain(), which causes TranslateManager to crash on startup since it requires |default_request_context_| to be initialized. So we forcibly initialize |default_request_context_| until TranslateManager stops depending on this. BUG=89396 TEST=none Review URL: http://codereview.chromium.org/7282054 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -145 lines) Patch
M chrome/browser/browser_main.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/browsing_data_appcache_helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_appcache_helper.cc View 5 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/download/download_file_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 4 chunks +49 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 3 chunks +10 lines, -1 line 0 comments Download
MM chrome/browser/net/pref_proxy_config_service_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/view_blob_internals_job_factory.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/net/view_blob_internals_job_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 9 chunks +17 lines, -21 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 5 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.h View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 5 chunks +7 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/testing_profile.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
9 years, 5 months ago (2011-07-15 10:11:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698