Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2081)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 738333002: Make goma work on win GN builds. (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix pdb flags Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | build/toolchain/win/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index 0d65c44da6405e085e737fc6ad50a1f47a13fdbb..957953df40ebfe25fda7afdc3363ca0669b95357 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -373,7 +373,9 @@ if (symbol_level == -1) {
}
# Symbol setup.
-if (symbol_level == 2) {
+if (is_win && use_goma) {
+ _default_symbols_config = "//build/config/compiler:no_symbols"
scottmg 2014/11/20 04:58:34 this should be minimal_symbols not no_symbols, oth
Dirk Pranke 2014/11/20 05:01:03 Okay, I will look into this more tomorrow.
+} else if (symbol_level == 2) {
Dirk Pranke 2014/11/20 03:47:13 I'm not sure if this is a great place for a win-go
_default_symbols_config = "//build/config/compiler:symbols"
} else if (symbol_level == 1) {
_default_symbols_config = "//build/config/compiler:minimal_symbols"
« no previous file with comments | « no previous file | build/toolchain/win/BUILD.gn » ('j') | build/toolchain/win/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698