Make goma work on win GN builds.

build/config/BUILDCONFIG.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # =============================================================================
 # BUILD FLAGS
 # =============================================================================
 #
 # This block lists input arguments to the build, along with their default
 # values. GN requires listing them explicitly so it can validate input and have
@@ skipping 355 matching lines @@
   # Linux is slowed by having symbols as part of the target binary, whereas
   # Mac and Windows have them separate, so in Release Linux, default them off.
   if (is_debug || !is_linux) {
     symbol_level = 2
   } else {
     symbol_level = 0
   }
 }
 
 # Symbol setup.
-if (symbol_level == 2) {
+if (is_win && use_goma) {
+  _default_symbols_config = "//build/config/compiler:no_symbols"

[scottmg, 2014/11/20 04:58:34]

this should be minimal_symbols not no_symbols, otherwise there will be no
stacktraces when there's a crash on a bot.

it shouldn't really be based on use_goma either i don't think, i think some
bots/people use_goma with win_z7 (which replaces /Zi with /Z7) to get symbols on
goma win builds.

but if you want to do this temporarily, it's ok as minimal_symbols.

[Dirk Pranke, 2014/11/20 05:01:03]

Okay, I will look into this more tomorrow.

+} else if (symbol_level == 2) {

[Dirk Pranke, 2014/11/20 03:47:13]

I'm not sure if this is a great place for a win-goma-specific block, but putting
things inside the configs in compiler/BUILD.gn seemed even worse.

   _default_symbols_config = "//build/config/compiler:symbols"
 } else if (symbol_level == 1) {
   _default_symbols_config = "//build/config/compiler:minimal_symbols"
 } else if (symbol_level == 0) {
   _default_symbols_config = "//build/config/compiler:no_symbols"
 } else {
   assert(false, "Bad value for symbol_level.")
 }
 _native_compiler_configs += [ _default_symbols_config ]
 
@@ skipping 305 matching lines @@
       if (defined(invoker.output_extension)) { output_extension = invoker.output_extension }
       if (defined(invoker.output_name)) { output_name = invoker.output_name }
       if (defined(invoker.public)) { public = invoker.public }
       if (defined(invoker.public_configs)) { public_configs = invoker.public_configs }
       if (defined(invoker.public_deps)) { public_deps = invoker.public_deps }
       if (defined(invoker.sources)) { sources = invoker.sources }
       if (defined(invoker.visibility)) { visibility = invoker.visibility }
     }
   }
 }