Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 738223002: [Extensions Toolbar Mac] Make new toolbar actions slide out from the right (Closed)

Created:
6 years, 1 month ago by Devlin
Modified:
6 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Mac] Make new toolbar actions slide out from the right New extension button should slide out from the right, instead of the left. Adjust the button's initial frame accordingly. BUG=429810 Committed: https://crrev.com/a7f80b66a74e9d4be407e1a61c090e3946f6b161 Cr-Commit-Position: refs/heads/master@{#305062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
Two more super-small ones for you, Avi.
6 years, 1 month ago (2014-11-19 23:51:15 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 1 month ago (2014-11-20 00:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738223002/1
6 years, 1 month ago (2014-11-20 18:31:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 19:38:07 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:38:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7f80b66a74e9d4be407e1a61c090e3946f6b161
Cr-Commit-Position: refs/heads/master@{#305062}

Powered by Google App Engine
This is Rietveld 408576698