chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm - Issue 738223002: [Extensions Toolbar Mac] Make new toolbar actions slide out from the right

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 738223002: [Extensions Toolbar Mac] Make new toolbar actions slide out from the right (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

index 495fb28428398f3bb156898e2b8c7966b6a8672c..b468630c68077f5e2f4ca100ebdaeb71e038d8a1 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

@@ -419,7 +419,7 @@ bool ToolbarActionsBarBridge::IsPopupRunning() const {

- (void)addViewForAction:(ToolbarActionViewController*)action

withIndex:(NSUInteger)index {

- NSRect buttonFrame = NSMakeRect(0.0,

+ NSRect buttonFrame = NSMakeRect(NSMaxX([containerView_ bounds]),

kBrowserActionOriginYOffset,

ToolbarActionsBar::IconWidth(false),

ToolbarActionsBar::IconHeight());

« no previous file with comments | « no previous file | no next file » | no next file with comments »