[turbofan]: More optimizations to add and subtract operations on x64

[turbofan]: More optimizations to add and subtract operations on x64

- Use "leal" for subtraction of integer constant when non-constant input to
  subtract is used more than once.
- Use "incl", "decl", and "addl" when they are smaller/cheaper than their
  leal/addl/subl equivalant.

R=titzer@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/5a494cf00ca4626758cc41e0ca800ebb0bff3a9b

[danno, 2014-11-19 15:45:02]

danno@chromium.org changed reviewers:
+ titzer@chromium.org

[danno, 2014-11-19 15:45:03]

PTAL. Chump change on zlib.

[titzer, 2014-11-20 12:39:24]

Looks good with a couple comments.

https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction...
src/compiler/instruction-selector.cc:157: bool
InstructionSelector::ValueOwnedBy(Node* owner, Node* value) const {
Maybe we can move this to a more generic location like NodeProperties?
Also, a test.

https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction...
src/compiler/instruction-selector.cc:160: for (Node::Uses::iterator current =
uses.begin(); current != uses.end();
You can use a C++ foreach here now!

[danno, 2014-11-20 13:43:07]

https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction...
File src/compiler/instruction-selector.cc (right):

https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction...
src/compiler/instruction-selector.cc:157: bool
InstructionSelector::ValueOwnedBy(Node* owner, Node* value) const {
On 2014/11/20 12:39:24, titzer wrote:
> Maybe we can move this to a more generic location like NodeProperties?
> Also, a test.

As discussed, the new patch set uses IsLive rather than this, so I removed it
completely.

[danno, 2014-11-20 13:43:20]

Please take another look

[titzer, 2014-11-20 13:47:50]

lgtm

[danno, 2014-11-20 13:48:54]

Committed patchset #5 (id:80001) manually as
5a494cf00ca4626758cc41e0ca800ebb0bff3a9b (presubmit successful).