content/common/message_port_messages.h - Issue 737833002: Properly queue messages sent to message ports that are transferred to a service worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/message_port_messages.h

Issue 737833002: Properly queue messages sent to message ports that are transferred to a service worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cross_process_messaging_with_terminate

Patch Set: format and comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/message_port_messages.h

diff --git a/content/common/message_port_messages.h b/content/common/message_port_messages.h

index 4269ade839e231c86c81ef2fd7acf6ea5655dae2..be435be33482b9ad6861e28475f6a4b4759ece25 100644

--- a/content/common/message_port_messages.h

+++ b/content/common/message_port_messages.h

@@ -83,3 +83,9 @@ IPC_MESSAGE_CONTROL1(MessagePortHostMsg_QueueMessages,

IPC_MESSAGE_CONTROL2(MessagePortHostMsg_SendQueuedMessages,

int /* message_port_id */,

std::vector<QueuedMessage> /* queued_messages */)

+// Tells the browser this message port is ready to receive messages. If the

+// browser was holding messages to this port because no destination for the

+// port was available yet this will cause the browser to release those messages.

+IPC_MESSAGE_CONTROL1(MessagePortHostMsg_ReleaseMessages,

+ int /* message_port_id */)

« no previous file with comments | « content/child/webmessageportchannel_impl.cc ('k') | no next file » | no next file with comments »