content/child/webmessageportchannel_impl.cc - Issue 737833002: Properly queue messages sent to message ports that are transferred to a service worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webmessageportchannel_impl.cc

Issue 737833002: Properly queue messages sent to message ports that are transferred to a service worker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cross_process_messaging_with_terminate

Patch Set: format and comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webmessageportchannel_impl.cc

diff --git a/content/child/webmessageportchannel_impl.cc b/content/child/webmessageportchannel_impl.cc

index fc6c8961f37a572c5905015ad618518cb905ccd0..c3de36fbeae7897e826edb5e4ac24f3b7a3d3705 100644

--- a/content/child/webmessageportchannel_impl.cc

+++ b/content/child/webmessageportchannel_impl.cc

@@ -165,6 +165,8 @@ void WebMessagePortChannelImpl::Init() {

DCHECK(message_port_id_ == MSG_ROUTING_NONE);

Send(new MessagePortHostMsg_CreateMessagePort(

&route_id_, &message_port_id_));

+ } else if (message_port_id_ != MSG_ROUTING_NONE) {

+ Send(new MessagePortHostMsg_ReleaseMessages(message_port_id_));

}

ChildThread::current()->GetRouter()->AddRoute(route_id_, this);

« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | content/common/message_port_messages.h » ('j') | no next file with comments »