Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 737523002: Sky: Move iframe geometry updates to FrameView::updateLayout instead of (Closed)

Created:
6 years, 1 month ago by Matt Perry
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Sky: Move iframe geometry updates to FrameView::updateLayout instead of RenderView::invalidateTree. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0db0d8d21be8448ea9975a226fb39f8fa0c1bdda

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M sky/engine/core/frame/FrameView.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderIFrame.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderIFrame.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Matt Perry
Is this what you had in mind?
6 years, 1 month ago (2014-11-17 19:59:31 UTC) #2
esprehn
https://codereview.chromium.org/737523002/diff/20001/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (right): https://codereview.chromium.org/737523002/diff/20001/sky/engine/core/frame/FrameView.cpp#newcode1129 sky/engine/core/frame/FrameView.cpp:1129: m_iframes.remove(iframe); I don't think you need this change, we ...
6 years, 1 month ago (2014-11-17 20:07:49 UTC) #3
Matt Perry
https://codereview.chromium.org/737523002/diff/20001/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (right): https://codereview.chromium.org/737523002/diff/20001/sky/engine/core/frame/FrameView.cpp#newcode1129 sky/engine/core/frame/FrameView.cpp:1129: m_iframes.remove(iframe); On 2014/11/17 20:07:49, esprehn wrote: > I don't ...
6 years, 1 month ago (2014-11-17 20:18:18 UTC) #4
esprehn
lgtm
6 years, 1 month ago (2014-11-17 20:48:10 UTC) #5
Matt Perry
6 years, 1 month ago (2014-11-17 20:49:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0db0d8d21be8448ea9975a226fb39f8fa0c1bdda.

Powered by Google App Engine
This is Rietveld 408576698