Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: sky/engine/core/rendering/RenderView.cpp

Issue 737523002: Sky: Move iframe geometry updates to FrameView::updateLayout instead of (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: compile Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderView.cpp
diff --git a/sky/engine/core/rendering/RenderView.cpp b/sky/engine/core/rendering/RenderView.cpp
index 44a01efe65b1f1a8916082d4a1254132ede607a1..796862d707412ea4f930d456e6551a5b08016dd6 100644
--- a/sky/engine/core/rendering/RenderView.cpp
+++ b/sky/engine/core/rendering/RenderView.cpp
@@ -299,11 +299,6 @@ void RenderView::invalidateTreeIfNeeded(const PaintInvalidationState& paintInval
const RenderLayerModelObject* paintInvalidationContainer = &paintInvalidationState.paintInvalidationContainer();
mapRectToPaintInvalidationBacking(paintInvalidationContainer, dirtyRect, &paintInvalidationState);
invalidatePaintUsingContainer(paintInvalidationContainer, dirtyRect, InvalidationFull);
-
- // Also need to handle iframes, since they have a separate view outside
- // the hierarchy.
- for (auto& iframe: m_iframes)
- iframe->invalidateWidgetBounds();
}
RenderBlock::invalidateTreeIfNeeded(paintInvalidationState);
}
@@ -769,4 +764,10 @@ void RenderView::removeIFrame(RenderIFrame* iframe)
m_iframes.remove(iframe);
}
+void RenderView::updateIFramesAfterLayout()
+{
+ for (auto& iframe: m_iframes)
+ iframe->updateWidgetBounds();
+}
+
} // namespace blink
« no previous file with comments | « sky/engine/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698