Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/unittest_util/page_test_test_case.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
index 136db6624afbac771ac6b8ebe815b8738a746604..e8782755030297e6adef06d7b96acec2f14bebda 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -134,24 +134,31 @@
perf.metrics.timeline_interaction_record module.
"""
- def __init__(self, overhead_level=NO_OVERHEAD_LEVEL):
+ def __init__(self):
super(TimelineBasedMeasurement, self).__init__('RunPageInteractions')
- self._overhead_level = overhead_level
+
+ @classmethod
+ def AddCommandLineArgs(cls, parser):
+ parser.add_option(
+ '--overhead-level', dest='overhead_level', type='choice',
+ choices=ALL_OVERHEAD_LEVELS,
+ default=NO_OVERHEAD_LEVEL,
+ help='How much overhead to incur during the measurement.')
def WillNavigateToPage(self, page, tab):
if not tab.browser.platform.tracing_controller.IsChromeTracingSupported(
tab.browser):
raise Exception('Not supported')
- assert self._overhead_level in ALL_OVERHEAD_LEVELS
- if self._overhead_level == NO_OVERHEAD_LEVEL:
+ assert self.options.overhead_level in ALL_OVERHEAD_LEVELS
+ if self.options.overhead_level == NO_OVERHEAD_LEVEL:
category_filter = tracing_category_filter.CreateNoOverheadFilter()
# TODO(ernstm): Remove this overhead level when benchmark relevant v8 events
# become available in the 'benchmark' category.
- elif self._overhead_level == V8_OVERHEAD_LEVEL:
+ elif self.options.overhead_level == V8_OVERHEAD_LEVEL:
category_filter = tracing_category_filter.CreateNoOverheadFilter()
category_filter.AddIncludedCategory('v8')
- elif self._overhead_level == MINIMAL_OVERHEAD_LEVEL:
+ elif self.options.overhead_level == MINIMAL_OVERHEAD_LEVEL:
category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
else:
category_filter = tracing_category_filter.CreateDebugOverheadFilter()
« no previous file with comments | « tools/telemetry/telemetry/unittest_util/page_test_test_case.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698