tools/telemetry/telemetry/unittest_util/page_test_test_case.py - Issue 737403002: Revert of telemetry: Remove command line args from page test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

Issue 737403002: Revert of telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr_unittest.py ('k') | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/unittest_util/page_test_test_case.py

diff --git a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

index 1239ac364a3181386e15340bfa5a49a71ea610e2..567bf1ae122c295144ac735008ef4f740813bd2c 100644

--- a/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

+++ b/tools/telemetry/telemetry/unittest_util/page_test_test_case.py

@@ -57,6 +57,8 @@

assert options

temp_parser = options.CreateParser()

page_runner.AddCommandLineArgs(temp_parser)

+ measurement.AddCommandLineArgs(temp_parser)

+ measurement.SetArgumentDefaults(temp_parser)

defaults = temp_parser.get_default_values()

for k, v in defaults.__dict__.items():

if hasattr(options, k):

@@ -69,6 +71,7 @@

options.suppress_gtest_report = True

options.output_trace_tag = None

page_runner.ProcessCommandLineArgs(temp_parser, options)

+ measurement.ProcessCommandLineArgs(temp_parser, options)

results = results_options.CreateResults(EmptyMetadataForTest(), options)

page_runner.Run(measurement, ps, expectations, options, results)

return results