Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 7374002: Refactor allocation policies.

Created:
9 years, 5 months ago by Vitaly Repeshko
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor allocation policies. Converted allocation policy classes from static namespaces to stateful objects. FooAllocationPolicy renamed to FooAllocator. This allowed zone allocation policy to have a direct pointer to the current zone instead of loading it from TLS. Slow ZoneList constructor was removed and a zone pointer was propagated to its former call sites. R=vegorov@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -448 lines) Patch
M src/allocation.h View 3 chunks +17 lines, -11 lines 0 comments Download
M src/allocation-inl.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 6 chunks +9 lines, -6 lines 0 comments Download
M src/ast.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M src/ast-inl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/func-name-inferrer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gdb-jit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 15 chunks +28 lines, -24 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/json-parser.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/jsregexp.h View 26 chunks +51 lines, -38 lines 0 comments Download
M src/jsregexp.cc View 58 chunks +145 lines, -110 lines 0 comments Download
M src/list.h View 4 chunks +21 lines, -11 lines 0 comments Download
M src/lithium.h View 3 chunks +7 lines, -5 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/liveedit.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parser.cc View 31 chunks +35 lines, -35 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/safepoint-table.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/safepoint-table.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M src/scopeinfo.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/scopeinfo.cc View 5 chunks +17 lines, -16 lines 0 comments Download
M src/scopes.cc View 4 chunks +29 lines, -29 lines 0 comments Download
M src/splay-tree.h View 6 chunks +17 lines, -10 lines 0 comments Download
M src/splay-tree-inl.h View 6 chunks +6 lines, -6 lines 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/v8globals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/zone.h View 3 chunks +28 lines, -12 lines 0 comments Download
M src/zone-inl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-list.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 11 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 5 months ago (2011-07-14 18:00:16 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 5 months ago (2011-07-15 12:20:58 UTC) #2
change LGTM 

but I think we should not commit it unless there is a significant improvement
from it because it pollutes interfaces with unnecessary details of allocation
and introduces tight coupling between objects (like e.g HGraph) and allocation
facilities (Zone).

Powered by Google App Engine
This is Rietveld 408576698