Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 737333002: Ignore pos argument if the first render object is not the current one. (Closed)

Created:
6 years, 1 month ago by zherczeg
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, leviw+bidiwatch_chromium.org, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Ignore pos argument if the first render object is not the current one. The pos argument defines a starting position inside the current render object. However, we might need to use another render object to determine the text direction. The pos position is invalid from the perspecitve of the other render object, so we pass 0 instead. BUG=377533 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185778

Patch Set 1 #

Total comments: 1

Patch Set 2 : Style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
A LayoutTests/fast/text/bdi-get-direction-crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/bdi-get-direction-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/BidiRunForLine.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zherczeg
Please review this patch.
6 years, 1 month ago (2014-11-20 11:12:43 UTC) #2
leviw_travelin_and_unemployed
lgtm. https://codereview.chromium.org/737333002/diff/1/Source/core/rendering/BidiRunForLine.cpp File Source/core/rendering/BidiRunForLine.cpp (right): https://codereview.chromium.org/737333002/diff/1/Source/core/rendering/BidiRunForLine.cpp#newcode86 Source/core/rendering/BidiRunForLine.cpp:86: RenderObject* firstRenderObject = Don't wrap this line.
6 years, 1 month ago (2014-11-20 23:34:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/737333002/20001
6 years, 1 month ago (2014-11-21 08:04:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 09:19:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185778

Powered by Google App Engine
This is Rietveld 408576698