Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: Source/core/rendering/BidiRunForLine.cpp

Issue 737333002: Ignore pos argument if the first render object is not the current one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Style fix Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/text/bdi-get-direction-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/BidiRunForLine.cpp
diff --git a/Source/core/rendering/BidiRunForLine.cpp b/Source/core/rendering/BidiRunForLine.cpp
index 9032966f7090d6e580bb424ef55d18c423062721..ffea34db61ad9db491f49989e2e34880d830758d 100644
--- a/Source/core/rendering/BidiRunForLine.cpp
+++ b/Source/core/rendering/BidiRunForLine.cpp
@@ -83,8 +83,8 @@ static RenderObject* firstRenderObjectForDirectionalityDetermination(
TextDirection determinePlaintextDirectionality(RenderObject* root,
RenderObject* current = 0, unsigned pos = 0)
{
- InlineIterator iter(root,
- firstRenderObjectForDirectionalityDetermination(root, current), pos);
+ RenderObject* firstRenderObject = firstRenderObjectForDirectionalityDetermination(root, current);
+ InlineIterator iter(root, firstRenderObject, firstRenderObject == current ? pos : 0);
InlineBidiResolver observer;
observer.setStatus(BidiStatus(root->style()->direction(),
isOverride(root->style()->unicodeBidi())));
« no previous file with comments | « LayoutTests/fast/text/bdi-get-direction-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698